Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdn,api): check workflow access with id, use workflow name from run #5753

Merged
merged 2 commits into from
Mar 9, 2021
Merged

fix(cdn,api): check workflow access with id, use workflow name from run #5753

merged 2 commits into from
Mar 9, 2021

Conversation

richardlt
Copy link
Member

Signed-off-by: richardlt [email protected]

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@richardlt richardlt force-pushed the fix-cdn-workflow-access-by-id branch from 26d089e to 92ec36b Compare March 8, 2021 18:00
@richardlt richardlt force-pushed the fix-cdn-workflow-access-by-id branch from 66a05b4 to 75274f7 Compare March 9, 2021 07:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.7% 70.7% Coverage
20.7% 20.7% Duplication

fsamin
fsamin approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merge, please check that workflowID is correctly defined in URL sanitizer for logs and doc

@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@richardlt
Copy link
Member Author

It's ok for workflowID. Here we panic at startup if we missed one value: https://github.com/ovh/cds/blob/master/engine/api/router.go#L183

@richardlt richardlt merged commit 28fcaed into master Mar 9, 2021
@richardlt richardlt deleted the fix-cdn-workflow-access-by-id branch March 22, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardlt @yesnault @fsamin @sguiheux