Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api,ui): run retention policy with feature flipping #5755

Merged
merged 1 commit into from
Mar 11, 2021
Merged

refactor(api,ui): run retention policy with feature flipping #5755

merged 1 commit into from
Mar 11, 2021

Conversation

richardlt
Copy link
Member

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@richardlt richardlt marked this pull request as draft March 9, 2021 15:51
@richardlt richardlt force-pushed the fix-cdn-retention-hide-dry-run branch from be7f63a to de0c135 Compare March 9, 2021 21:38
@richardlt richardlt changed the title fix: show dry run only if retention enabled, fix sql rollback for policy refactor(api,ui): run retention policy with feature flipping Mar 9, 2021
@richardlt richardlt force-pushed the fix-cdn-retention-hide-dry-run branch from de0c135 to d986f39 Compare March 9, 2021 21:42
@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@ovh ovh deleted a comment from ovh-cds Mar 9, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

59.2% 59.2% Coverage
5.2% 5.2% Duplication

@richardlt richardlt marked this pull request as ready for review March 11, 2021 09:58
@fsamin fsamin merged commit 6a77e84 into master Mar 11, 2021
@richardlt richardlt deleted the fix-cdn-retention-hide-dry-run branch March 22, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardlt @yesnault @fsamin @sguiheux