Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hatchery): inject env variables into workers from hatchery config #5806

Merged
merged 3 commits into from
May 18, 2021
Merged

feat(hatchery): inject env variables into workers from hatchery config #5806

merged 3 commits into from
May 18, 2021

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented May 7, 2021

No description provided.

richardlt
richardlt reviewed May 7, 2021
View reviewed changes
engine/service/types.go Outdated Show resolved Hide resolved
engine/config.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 7, 2021

CDS Report build-all-cds#15994.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin
fix: cr
25d4fd0 
Signed-off-by: francois  samin <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
12.8% 12.8% Duplication

@sguiheux sguiheux merged commit 70909f2 into master May 18, 2021
@fsamin fsamin deleted the feat/hatchery/inject_env_variables branch June 25, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt