Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): don't change workflow permission for as-code #6090

Merged
merged 5 commits into from
Feb 16, 2022
Merged

fix(api): don't change workflow permission for as-code #6090

merged 5 commits into from
Feb 16, 2022

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Feb 16, 2022

No description provided.

sguiheux
sguiheux approved these changes Feb 16, 2022
View reviewed changes
engine/api/workflow/workflow_importer.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 16, 2022

CDS Report build-all-cds#17071.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

96.2% 96.2% Coverage
0.0% 0.0% Duplication

@fsamin fsamin merged commit b9151b4 into master Feb 16, 2022
@fsamin fsamin deleted the fix_workflow_as_code_permission branch February 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsamin @ovh-cds @sguiheux @richardlt