Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rbac middleware system #6103

Merged
merged 13 commits into from
Mar 21, 2022
Merged

feat: add rbac middleware system #6103

merged 13 commits into from
Mar 21, 2022

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Mar 2, 2022

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

fsamin
fsamin requested changes Mar 2, 2022
View reviewed changes
engine/service/http.go Outdated Show resolved Hide resolved
engine/api/router_middleware_rbac.go Show resolved Hide resolved
engine/api/router_middleware_rbac.go Outdated Show resolved Hide resolved
engine/api/v2_project.go Outdated Show resolved Hide resolved
engine/api/rbac/project.go Outdated Show resolved Hide resolved
@sguiheux sguiheux requested a review from fsamin March 3, 2022 09:25
@sguiheux sguiheux requested review from fsamin and richardlt March 11, 2022 13:17
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 11, 2022

CDS Report build-all-cds#17148.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh ovh deleted a comment from ovh-cds Mar 14, 2022
@ovh ovh deleted a comment from ovh-cds Mar 14, 2022
fsamin
fsamin requested changes Mar 14, 2022
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ sed s/Rbac/RBAC/

engine/api/rbac/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/rbac/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/rbac/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/rbac/dao_rbac_global.go Outdated Show resolved Hide resolved
engine/api/rbac/dao_rbac_global.go Outdated Show resolved Hide resolved
engine/api/rbac/loader.go Show resolved Hide resolved
engine/api/user/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/user/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/v2_project.go Outdated Show resolved Hide resolved
engine/api/v2_project.go Show resolved Hide resolved
richardlt
richardlt requested changes Mar 14, 2022
View reviewed changes
engine/api/rbac/dao_rbac.go Show resolved Hide resolved
engine/api/rbac/dao_rbac.go Outdated Show resolved Hide resolved
engine/api/rbac/loader.go Outdated Show resolved Hide resolved
engine/api/rbac/loader.go Outdated Show resolved Hide resolved
sdk/rbac.go Outdated Show resolved Hide resolved
sdk/rbac_global.go Outdated Show resolved Hide resolved
sdk/rbac_global.go Outdated Show resolved Hide resolved
sdk/rbac_global.go Outdated Show resolved Hide resolved
sdk/rbac_global.go Outdated Show resolved Hide resolved
sdk/rbac_project.go Outdated Show resolved Hide resolved
yesnault
yesnault requested changes Mar 14, 2022
View reviewed changes
sdk/rbac_project_test.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 14, 2022

CDS Report build-all-cds#17151.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 14, 2022

CDS Report build-all-cds#17151.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 14, 2022

CDS Report build-all-cds#17151.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

fsamin
fsamin requested changes Mar 15, 2022
View reviewed changes
engine/api/router_middleware_rbac.go Outdated Show resolved Hide resolved
richardlt
richardlt requested changes Mar 21, 2022
View reviewed changes
engine/api/rbac/dao_rbac_project_group.go Outdated
continue
}
}
return rbacGroupIDs, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need filter to remove the entity with invalid signature.

engine/api/rbac/dao_rbac_project_project.go Outdated Show resolved Hide resolved
engine/api/rbac/dao_rbac_project_user.go Outdated Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
engine/api/rbac/gorp_model.go Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 21, 2022

CDS Report build-all-cds#17174.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.5% 75.5% Coverage
0.0% 0.0% Duplication

@sguiheux sguiheux merged commit fce41f8 into master Mar 21, 2022
@yesnault yesnault deleted the rbacArch branch April 1, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt