feat(api,cli,ui): disable project key #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
changed the title
richardlt
approved these changes
Jan 24, 2023
sguiheux
requested changes
Jan 24, 2023
|
|
||
| -- +migrate Up | ||
| ALTER TABLE project_key ADD COLUMN disabled BOOLEAN NOT NULL DEFAULT FALSE; | ||
| UPDATE project_key SET disabled = false; |
There was a problem hiding this comment.
DEFAULT false is not updating all existing rows ?
If there is lots of values the right pattern is:
ALTER TABLE project_key ADD COLUMN disabled BOOLEAN NOT NULL;
UPDATE project_key SET disabled = false;
ALTER TABLE "project_key" ALTER COLUMN disabled SET DEFAULT false;
There was a problem hiding this comment.
DEFAULT false is not updating all existing rows ?
nope
there are not so much rows (1468) in the table
Co-authored-by: Guiheux Steven <[email protected]>
sguiheux
approved these changes
Jan 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
yesnault
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.