Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): dropped api error #6445

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix(engine): dropped api error #6445

merged 1 commit into from
Feb 9, 2023

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Feb 7, 2023

This fixes a dropped err variable in the engine/api package.

@ovh/cds

richardlt
richardlt requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@richardlt richardlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to return an error that will give more info to the client. Returning only err will result in an HTTP 500 response.

engine/api/v2_project.go Outdated Show resolved Hide resolved
@alrs
fix(engine): dropped api error
57596b1 
Signed-off-by: Lars Lehtonen <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 9, 2023

CDS Report build-all-cds#18505.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@richardlt richardlt merged commit a0ed12c into ovh:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alrs @ovh-cds @sguiheux @richardlt