Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): manage variable deletion and env keys as code #6563

Merged
merged 7 commits into from
Jun 7, 2023
Merged

fix(api): manage variable deletion and env keys as code #6563

merged 7 commits into from
Jun 7, 2023

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jun 2, 2023

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux changed the title fix: manage variable deletion and env keys as code fix(api): manage variable deletion and env keys as code Jun 2, 2023
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2023

CDS Report build-all-cds#18862.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

fsamin
fsamin reviewed Jun 2, 2023
View reviewed changes
engine/api/environment/environment_importer.go
break
}
if err := InsertVariable(db, into.ID, &env.Variables[i], u); err != nil {
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more msgChan <- sdk.NewMessage ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2023

CDS Report build-all-cds#18863.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 2, 2023

CDS Report build-all-cds#18864.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 5, 2023

CDS Report build-all-cds#18870.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit b1430bc into master Jun 7, 2023
@sguiheux sguiheux deleted the fixenvKeys branch June 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt