From b1aa99d24bf8883315c366d520b84c3f92ac0b39 Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Sat, 29 Feb 2020 16:08:43 +0100 Subject: [PATCH 1/6] perf(ui): update loader Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.icon.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/src/app/shared/status/status.icon.html b/ui/src/app/shared/status/status.icon.html index 1c939355f1..b471d35645 100644 --- a/ui/src/app/shared/status/status.icon.html +++ b/ui/src/app/shared/status/status.icon.html @@ -1,9 +1,9 @@
-
+ {{value}} -
+
From 0fab8c7d309979e62fc56b08168688e230918950 Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Sat, 29 Feb 2020 16:42:33 +0100 Subject: [PATCH 2/6] fix: ut Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/app/shared/status/status.spec.ts b/ui/src/app/shared/status/status.spec.ts index 7162fdda6a..c5aada51b7 100644 --- a/ui/src/app/shared/status/status.spec.ts +++ b/ui/src/app/shared/status/status.spec.ts @@ -44,7 +44,7 @@ describe('CDS: Parameter Value Component', () => { tick(50); let compiled = fixture.debugElement.nativeElement; - expect(compiled.querySelector('.blue.loader')).toBeTruthy('Building loader not displayed'); + expect(compiled.querySelector('.spinner.blue.icon')).toBeTruthy('Building loader not displayed'); })); it('should display fail icon', fakeAsync(() => { From 28731a00cc85c0e2336f7035299412a2cbae200c Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Mon, 2 Mar 2020 10:30:09 +0100 Subject: [PATCH 3/6] fix: gif version Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.icon.html | 4 ++-- ui/src/app/shared/status/status.spec.ts | 2 +- ui/src/assets/images/loader.gif | Bin 0 -> 673 bytes 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 ui/src/assets/images/loader.gif diff --git a/ui/src/app/shared/status/status.icon.html b/ui/src/app/shared/status/status.icon.html index b471d35645..d1636c439c 100644 --- a/ui/src/app/shared/status/status.icon.html +++ b/ui/src/app/shared/status/status.icon.html @@ -1,8 +1,8 @@
- - {{value}} + + diff --git a/ui/src/app/shared/status/status.spec.ts b/ui/src/app/shared/status/status.spec.ts index c5aada51b7..70d3577ade 100644 --- a/ui/src/app/shared/status/status.spec.ts +++ b/ui/src/app/shared/status/status.spec.ts @@ -44,7 +44,7 @@ describe('CDS: Parameter Value Component', () => { tick(50); let compiled = fixture.debugElement.nativeElement; - expect(compiled.querySelector('.spinner.blue.icon')).toBeTruthy('Building loader not displayed'); + expect(compiled.querySelector('.gifloader')).toBeTruthy('Building loader not displayed'); })); it('should display fail icon', fakeAsync(() => { diff --git a/ui/src/assets/images/loader.gif b/ui/src/assets/images/loader.gif new file mode 100644 index 0000000000000000000000000000000000000000..d0bce1542342e912da81a2c260562df172f30d73 GIT binary patch literal 673 zcmZ?wbhEHb6krfw_{6~Q|Nnmm28Kh24mmkF0U1e2Nli^nlO|14{Lk&@8WQa67~pE8 zXTZz|lvDgC+Z`3#dv5h=E26FfcG1 zbL_hF&)}42ws10s6^G;;cE1^EoUR)U5A70}d2pLv!jVIT7j&Z~EblI3x0K*v_sV|m z0kj3v921Z^em#l`(k(o@H$3ZdDRc@9NidXDNbqrumReCGv$gd8+e8WW28HVqkJ_9i zH>s*<31KtHjANIPvi2#*6BEu%3Dak5O_t&NBI)H?V$TxT}#l{vOTn5naXTfF^&~Hhq+NX@#Ccc>y7T?;vjI&jdhsDsPJyAw*m0Qz>i}K7# zL9w50Ng{fT}A5JUe8lRK1h7_Y2;BWJDd=c6f&i?Wv5(5q?6|P zQw{>maxZP<537OA37Uk}7@%_$4o$EWe_Zl>&#id|lE-BpDC#+Fn|msJ%_2h{Hg1vP z#N8WAzfWasG}yq|xqE)DrWaOofX=z|?*pgc%{ig5vl!pqDlC|q&~Z0$&Rvsft&VO- z4MZj+%-+Vx%W}v;V76hyp=;+R;x+~t^Q%*xuFTQAF2})fSfTHDAs>sO!OBw`)&)o$ c0!CNZt))x~rAZP^^P&YOFfdqy5)K#u0POD40{{R3 literal 0 HcmV?d00001 From e351b65e128ffe3def2467b58e558d13d44771ef Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Mon, 2 Mar 2020 10:57:37 +0100 Subject: [PATCH 4/6] fix: ut Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/app/shared/status/status.spec.ts b/ui/src/app/shared/status/status.spec.ts index 70d3577ade..1185244821 100644 --- a/ui/src/app/shared/status/status.spec.ts +++ b/ui/src/app/shared/status/status.spec.ts @@ -44,7 +44,7 @@ describe('CDS: Parameter Value Component', () => { tick(50); let compiled = fixture.debugElement.nativeElement; - expect(compiled.querySelector('.gifloader')).toBeTruthy('Building loader not displayed'); + expect(compiled.querySelector('#gifloader')).toBeTruthy('Building loader not displayed'); })); it('should display fail icon', fakeAsync(() => { From 58893430e07a0e6545cf006838ebacfba58ab563 Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Mon, 2 Mar 2020 17:33:39 +0100 Subject: [PATCH 5/6] fix: cr Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.component.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/src/app/shared/status/status.component.ts b/ui/src/app/shared/status/status.component.ts index 73cde34f7c..f535103051 100644 --- a/ui/src/app/shared/status/status.component.ts +++ b/ui/src/app/shared/status/status.component.ts @@ -9,7 +9,6 @@ import { PipelineStatus } from 'app/model/pipeline.model'; }) export class StatusIconComponent { @Input() status: string; - @Input() value: string; @Input() optional: boolean; @Input() loader = true; pipelineStatusEnum = PipelineStatus; From 94cb6e1a1dd81489fabcc1fd020a8e790cb79aac Mon Sep 17 00:00:00 2001 From: Yvonnick Esnault Date: Mon, 2 Mar 2020 17:45:13 +0100 Subject: [PATCH 6/6] fix: cr Signed-off-by: Yvonnick Esnault --- ui/src/app/shared/status/status.component.ts | 1 - ui/src/app/shared/status/status.icon.html | 5 +---- ui/src/assets/images/loader.gif | Bin 673 -> 6259 bytes 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/ui/src/app/shared/status/status.component.ts b/ui/src/app/shared/status/status.component.ts index f535103051..117c1243f0 100644 --- a/ui/src/app/shared/status/status.component.ts +++ b/ui/src/app/shared/status/status.component.ts @@ -10,7 +10,6 @@ import { PipelineStatus } from 'app/model/pipeline.model'; export class StatusIconComponent { @Input() status: string; @Input() optional: boolean; - @Input() loader = true; pipelineStatusEnum = PipelineStatus; constructor() { } diff --git a/ui/src/app/shared/status/status.icon.html b/ui/src/app/shared/status/status.icon.html index d1636c439c..43fb714eb1 100644 --- a/ui/src/app/shared/status/status.icon.html +++ b/ui/src/app/shared/status/status.icon.html @@ -1,10 +1,7 @@
- - - - + diff --git a/ui/src/assets/images/loader.gif b/ui/src/assets/images/loader.gif index d0bce1542342e912da81a2c260562df172f30d73..2c246bb9e5312a501c2281ac6f65afdb0a634707 100644 GIT binary patch literal 6259 zcmc(jeLT|(-^YJ@o|)N`**tDDPaU~d9zstW!!R|^k~B5XWSFO-voT32LZXmFA{7-X zPG=|~)sjl38tGZ3jyiQNIrp!tb9K&rU-y0ecfIc4pTB>8uf1OH_xJPp%-zGy!7-cz zaDWB?5Y$a|Kb*}vKRxwkuB?Ard}3Fn%pbHkIfg}u}D*JeYTrxd-@(;w%mu1!lj zrv2-tE&;jM->4i&IK58}hw(ly+M`UOrGbndE!>H&xueUx2^jLwCp69sH0aF?6KwaI8YO^5B#Y^vI2H{|DB zt-x*%Ztb{w+rE0mPt-7uSlLq;i~qI$$Y3A&#I`uDy34P35kTB=M(2a0vG82SOUk0+ z9ju_nmDi7CJMvtd6=}9v>xep?hR3=pSx*)mikFzV>@-?`t@~UFguK9NMkwzEp1ED7ERv<(l5)Rng^TKS7Vztqv=eU`&91QK`Db8uppiQ3L2DSc|ggP}TBzx-q=FI}S8fNG; zLCv-8UxLmK;ipa*|7;3@LeY{Azl>snnXH&0o0)(;{ZRiPp-iY^5zYX5t^vlTG z3*|_|pbbml=r0gueZ>l>qv`(mju%f4tcFAWpwIYE`V^pIEhDp_CZJ`YVxT^tU*Bv3 zB?A3Ab8i+@4D=3^>&)$0&_vKLP%cm+&@9lwmfN$SU!Yu|m7s~BS)gm6S@k2cpj?P~ zwfSywOigt2iTGC+Bv#jFL+CgeIrXilOpR14KkYu6Q*1HCILL&HD)e90UdP#;9hbIR z4lt6N(7x5<(sf^QysC4Zo;jTL9yzpPd&YqUUU7hq2RAlum4%@Z8f}!$h6d#LN11ct z0pbFruM~}3oV=|v*K$c#frU)2SOm+dcY&?W^vYhOTN>zmhVM{zmR+${KkxwG=+u!# z(6wc_a`)=aLv^J&s9Ccgpgaup~-?aI?0d;f0m?{ex=Dc|Jd!k*z7%6C@s<)(H$)f|$( z&fx@eib0NIQZ2NPu8GU|$r3<~pg zE(CcT!s9Qj`?&u;8(TJIH^_Z}Yh{3f#<^GR`r)~nAMQNd?gh^%&nojjnx7rD>;14xYWFR!=c6@pPPirw-^0*u?i3prF0^}D28N?RE5QG$r1(0GeF23^%#=CN;gQX z1Ykw(lu!wl;!UsiBjuHdNuKxw9PF?c5*3O<`q8n8l1I`c9vi5q;%C~6K$;DwOaTe)Mx?)%g_e5Y7#TH)+y;9Ec z8^p#m!8`!kAT#C@8-{3?JRYj{S|Z-AfpQY4_G|X#qA(qDLa|?IJ_34Vney^;E)|;Q zxtWf?#B@3nykZY4-@J_kziaC#8ULHJ{UE@Mwql0g2uPkdYBBRE*<98sU@I14I9wh7 zDe245{q@c>`xFc45C#V(#{+qU-j`R$OHfTGaK4*7T&@ZbctBsbTxj;nQ+j8WYyT30 zhVBKAWJwQsL2P4?-6G}LsRLs!(u-k?jRmzplq=%$KB9J2n-Ng26)q3&a-{D>(|K&I zRB`6fkBW%kOd;K!v6Vz3FdWeSW=86daOkJv9*%-n;dV8EK!#Li|Nkck#EK_dR> zEHM^A<&McT&t~x9mmgHv$16KU zE>osQC>o!*4Lk08V!-`hn#fm|zzYwG1a_qFB7q8lB7qix3W0)w@_-_No`BAPS@2yX zFf2gjz#ss10$Ud7(l?7hg+P(MSp=%}AFW&e(xkq*nz%_VTn*lN$-Di`_ z2*3tzn3SG7w==0yH)jyG7xON{-dqA;1?42%4Hd1{g>r*aQSN z8hg-}UKTB)N8lueIDfiCl-VlAiA3%GjmbwF8iA&O($nRsi0Wp4RHGqv-=0u<*PZ+0 z4<0^JPfR|(Z%jn$6OE??u&4_$8ZZwdm@YxBnVAzCqv>YEntes@ap~0l5_!(kCXp`} zo>Q@8{g+)#e2$N>*%mApo)4|VJJeP8p5scN&B70Tbw2> zSkU34#L)NLPdY*Q8t%-{PqMcME;M3d+FT~Bo4R{u&G=)*o1kki7MplQK0DM4gBn=* zKVSMJ7Xs11wwTz+l+J8;q0>7N(5eS3I+i61I+Yu1c035mmNm#;D82|U2fmjdypB73 z49Z3kNvHRsILR&1yxvi^;s@b`y9)Y(;;l9(=&{ zI0JI0HqCIPIeeGr-vkkuLZCvR z2H#T%)Z_bT`J+hnPJ{k{MuGBtEm%jUzQ++bPC$#mngv<}7AeplP@eyfAR3FOOvT8~ zh)ga)S{?Ai+HQw?vU&xpX~2wyDa7S2lnrM|JhZa1ARcs>G%E!#M9AGYN^xX95mUG` z1(WD&tfNycAZvwr=vMA%-sVHyoK0Or#3`C9adqCtn-$2SAZk-#3WXumxhU-qf_LoS z55R?tYdXR3c4?ntWOY|FQWiAYe*GQ=>H|e)AzuU=i&Z;!;wFX08iz!XC)a=$y6ZWy z*IoqTSGY4*Eb%kV^P5qPJXLG+elUjP=>TKmQW4!{he6Ymz8oyl3>#d$v%Um>GWML; zdk7?_T-POd!0qk2d4g6qR{Hl(3u$c<*Zs@&G4FcVhXD%Saser-7Bc^QFO36-_-o=< z^p8f4a)MH_RH5QKGoc5Yx~a5QjQNdjL1=-kSHJ%R?8i-zWo&2lUR5z7to`+4p8*sa z{~XiOTH3;tTJQ50{ctnnsVUJ&Tp^fyc^0lQh$p@Uvl@HwrQp>q(nhDvSN2l0d`w^X^G*(B^P5k{IiN@!GQiu8y5)7M(Heqnk50526P|5?1^oVTdqOKG!H&ND+>SgX_U!5g?t?Jq0MY^yXko|UVfkKxhWx|)lTlZQ7>uzerv?P zT_9kh{Mq1!zBV{e3b4C@u9f=0wV{M2rO%0Ac5|Hf^^@T1#JQ+3aHH2aQf%` z05=SnQh!+>p)OjmTaqYnfsBh~u;|R&qe@Y0-OYE>r3%TQfnA1doqw~J?MXY_wTeOrNqoIH6KrNafDMKklA()2)>TUYk%|7kOealmsGi#ybB*J!8G0*C zDCZg@A>MnJRhpwiH|yz9Opo~u`koY^hVGaz30sD^%GzC1gPZc|i|k))Kp^Ylt;0=g zk}MI*18j`pOnc@G`rdACU4P4t$9Z8qs{^+y_t0NVQenr+Vq~ftCi*K;^H8qs;Hicy z``8fx=Zi!7^yi5{3HB@C=Grpsao`Z#HG1Xav?0c05O^6l)hm@YfnxVyHxu{p^ z&%%`NuabEcRW?LOXxTB>_D@gbUPUL2Vf8CofXOU^% zD-9SyZ+pU^iUA&_W`WJ^0@gc=jv^nY{ucS*-LD@drx9s8->D6XP-gn)>4V(gJnc^3Ru&}& zT<}08gg~UC-te<0r)_-U=o#m2`O&YkF7r|%xu_6iNJNAxZ2e@k(2&&Y>NAej6twS# z_Ef11WB_#xzDYYeD#vk?qeO;<3sSd3jZW2bvV>%IE<|TIP@X_Ys=d0F*&KPu0n=^P ztG|yUUlpeV4d!ff-X!ZIU@#szTjxGlJlX4*_s=$E@aHo5=d%8nW%3Pb5ZiCb04`{d z>u*GZ%>Fe2z^nfi@PBL)kZUjs{#u_9^Yrh_`U;I$#&Qvz%{Z~R02U3%OnOwbUD$&& zx^p^3s=bUh_+oj%T4@}{DwosnH)X^^y;Jb|HV3Y3=12g{ve9anL`T(Hc2u+_P$SKp zLSCQ3C2uv+OOglZZNtE9V3=JFT0wgx1Qx!a21qqU)@_#395g-UE812jFvA2ZiuJ@S zN}Xp4e*X`;)juZ#x+Z=*wyZJ5R12Ij)^%QI<$*_-+9M~OwaxUoV`DID|G>-Zaiy$f zV?{jk<=*R^6$^`kn&qEaNNBxW1aozYNt!?2YL5wQT6lYM&(b?N!3G7Q5?6WTB`OfR zF!aGM{R&E1*x~uCczg#F>K30hB<6pJ$ffA!8(a$)Uv_Trsw`B8AL-%3%k$1w(WpJ* zkw)QR&uY*1=3B>tweZ{Va;0~R(*mJSNiB4&)e=(S%1|pIkf`;AKYi${EYL_Xs|ry2 z=xrmR>J1&@7U?_gGKJdEu=Y7MKDBQsUk>S7xhtmTYbw+oi^nW4OYZLKs)GuCfb+ZP z5i9aOIIoX!->fzO{&bN=0x$caaZMbO*Bz2iGp^;6x=!P%!mZ>cv=e>46 z1H8*K$=lGKPo7gOL$42hv86}c@ZR%zF~!HW3^!0Y?1&Va;%*B3m=;GG69?l*M54FM2c z@E(6HG9d8(SOH(lOUKu%{H_20kMjRldY4lAglDA>0&%rb{t>@(b~9mgqCU-4GT4lV zXstW*d}E0Bxfj3i&z-l`FE9&`QLe644j<5S=-Ay8bL!Z^L!^%$eMj93up3#V5Z`DZ z(}GB)qPW>nKRN+e(+KzU)mm|;C}^Y>lxQ#Y$=g$4Le7i9nWK>DP8x@89iw9WPOxBZ zrS7x<(}N{69@JKk=C?JKmSf_wXQ`(dDlc#MLe#a$n_Bl+I?%PtEijc^Z&}^B`Gz-9 z4%4YJr{&^v-CaaXytHur*&WjxoZsjJVq0{>O~vyeIlK`|7DKorO`c)) zRw|~*L{ketf8JH2KEDs*W)^c+UfSGXq(!vnwSs?#dTRmMA(b4!LcU>ob za8J7a(fh)k#hcds7&4o@a7*Ap(_?S0MH{}Vk!x8NT60m))BV=-KRwGK z{n+jC%oX>=3eH2o>9w`G+E(S<%;9hu0KITr0_2iK{7~Q_e8v!isNd6*{3t+807x|z zlYUlP-6v^gHQRHx8N7V{xQK&1$3p{4qZ7TCM6Hnuy`zJ8i`i+CRLK&D1Y4gNA0BTr ppYI#!VJl5biVy~Kol}CmgX}lh*o3=!CZ^ii#&1fL{4F);zW@sGUfBQu literal 673 zcmZ?wbhEHb6krfw_{6~Q|Nnmm28Kh24mmkF0U1e2Nli^nlO|14{Lk&@8WQa67~pE8 zXTZz|lvDgC+Z`3#dv5h=E26FfcG1 zbL_hF&)}42ws10s6^G;;cE1^EoUR)U5A70}d2pLv!jVIT7j&Z~EblI3x0K*v_sV|m z0kj3v921Z^em#l`(k(o@H$3ZdDRc@9NidXDNbqrumReCGv$gd8+e8WW28HVqkJ_9i zH>s*<31KtHjANIPvi2#*6BEu%3Dak5O_t&NBI)H?V$TxT}#l{vOTn5naXTfF^&~Hhq+NX@#Ccc>y7T?;vjI&jdhsDsPJyAw*m0Qz>i}K7# zL9w50Ng{fT}A5JUe8lRK1h7_Y2;BWJDd=c6f&i?Wv5(5q?6|P zQw{>maxZP<537OA37Uk}7@%_$4o$EWe_Zl>&#id|lE-BpDC#+Fn|msJ%_2h{Hg1vP z#N8WAzfWasG}yq|xqE)DrWaOofX=z|?*pgc%{ig5vl!pqDlC|q&~Z0$&Rvsft&VO- z4MZj+%-+Vx%W}v;V76hyp=;+R;x+~t^Q%*xuFTQAF2})fSfTHDAs>sO!OBw`)&)o$ c0!CNZt))x~rAZP^^P&YOFfdqy5)K#u0POD40{{R3