Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Issues and improvements for geo.add_region_aggregates #53

Open
Tracked by #779
pabloarosado opened this issue Nov 2, 2022 · 2 comments
Open
Tracked by #779

Issues and improvements for geo.add_region_aggregates #53

pabloarosado opened this issue Nov 2, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@pabloarosado
Copy link
Collaborator

pabloarosado commented Nov 2, 2022

Let's gather here all issues that the function currently has, and possibly consider the features that it should have in the near future.

@pabloarosado
Copy link
Collaborator Author

  1. Given a wide dataframe with country, year, and several data columns, when an aggregate is added (e.g. "Europe") just for one of the columns (and no aggregation is specified for the rest of the columns) and there was already data for that region, the data for the rest of columns is deleted for that particular region (in this line). This is an unusual scenario, because you would normally want to replace all data for a certain region, not just certain columns. However, the expected behaviour would be to just replace the region data for the specified column.

@pabloarosado pabloarosado added bug Something isn't working enhancement New feature or request labels Nov 2, 2022
@lucasrodes
Copy link
Member

  1. This seems to be the only dependency between datautils and owid-catalog. Would be great if we made steps towards reducing (or even eliminating) this dependency. More details in this thread: https://owid.slack.com/archives/C0193RW5E2J/p1670340579873829

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants