Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate configs in R2 on chart config migrations #4218

Open
sophiamersmann opened this issue Nov 26, 2024 · 0 comments
Open

Migrate configs in R2 on chart config migrations #4218

sophiamersmann opened this issue Nov 26, 2024 · 0 comments

Comments

@sophiamersmann
Copy link
Member

I blanked on R2 while working on this chart config migration. The code that I pushed didn't handle the old config format, which meant that embedded charts were rendered incorrectly until the syncing script did its job (and Marcel figured out a caching issue).

As a small solution, we should run the R2 syncing script automatically when charts configs have been migrated. (Or just run it regularly, like hourly).

If we can come up with a way to do this that doesn't force us to write code that handles the old and new config format simultaneously, that would be even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant