[tests-only][full-ci] Store share invite response #10994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
store-share-invite-response
branch
from
cdfb50e to
9d27882
Compare
amrita-shrestha
requested review from
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
nabim777,
S-Panta and
PrajwolAmatya
|
PrajwolAmatya
approved these changes
Feb 13, 2025
saw-jan
requested changes
Feb 13, 2025
| @@ -691,6 +697,12 @@ public function updateResourceShare(string $user, TableNode $body, string $perm | |||
| \json_encode($body), | |||
| $permissionID | |||
| ); | |||
|
|
|||
| if ($response->getStatusCode() === 200) { | |||
| $this->featureContext->shareNgAddToCreatedUserGroupShares($response); | |||
There was a problem hiding this comment.
for update response, we should update the share instead of adding to the list. Check if shareNgAddToCreatedUserGroupShares method updates the share data properly
Suggested change
| $this->featureContext->shareNgAddToCreatedUserGroupShares($response); | |
| $this->featureContext->shareNgAddToCreatedUserGroupShares($response); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stores share related response to use in later step to get permission id and expiration date
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: