file publishing should report errors

[jclulow]

At present, if you add a [[publish]] directive to the TOML, but something about it was wrong, we not only do not fail the job but we don't even report the problem. This happens in wollogong, in the basic variety code:

            /*
             * Resolve any publishing directives.  For now, we do not handle
             * publish rules that did not match any output from the actual job.
             * We also do not yet correctly handle a failure to publish, which
             * will require more nuance in reported errors from Dropshot and
             * Progenitor.  This feature is broadly still experimental.
             */
            for p in c.publish.iter() {
                if let Some(o) =
                    outputs.iter().find(|o| o.path == p.from_output)
                {
                    b.job_output_publish(
                        jid,
                        &o.id,
                        &buildomat_openapi::types::JobOutputPublish {
                            series: p.series.to_string(),
                            version: cs.head_sha.to_string(),
                            name: p.name.to_string(),
                        },
                    )
                    .await
                    .ok();
                }
            }

buildomat/github/server/src/variety/basic.rs

Lines 420 to 443 in 085e768

	/*
	* Resolve any publishing directives. For now, we do not handle
	* publish rules that did not match any output from the actual job.
	* We also do not yet correctly handle a failure to publish, which
	* will require more nuance in reported errors from Dropshot and
	* Progenitor. This feature is broadly still experimental.
	*/
	for p in c.publish.iter() {
	if let Some(o) =
	outputs.iter().find(|o| o.path == p.from_output)
	{
	b.job_output_publish(
	jid,
	&o.id,
	&buildomat_openapi::types::JobOutputPublish {
	series: p.series.to_string(),
	version: cs.head_sha.to_string(),
	name: p.name.to_string(),
	},
	)
	.await
	.ok();
	}
	}

It is probably time to consider this less experimental:

• publish directives for files not produced as output artefacts should be reported and fail the job
• publish failures for otherwise present output artefacts should be also be reported and fail the job