Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibreSSL and BearSSL #327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add LibreSSL and BearSSL #327

wants to merge 3 commits into from

Conversation

daviduhden
Copy link

I have added LibreSSL and BearSSL to the cryptography section. On the other hand, I have also added the original OpenSSL license to the license list and improved the comment about the license under which the OpenSSL software is currently licensed.

I have added LibreSSL and BearSSL to the cryptography section. On the other hand, I have also added the original OpenSSL license to the license list and improved the comment about the license under which the OpenSSL software is licensed.
@shlomif
Copy link
Contributor

shlomif commented Jul 29, 2024

@daviduhden : hi! Thanks for the patch. Note that I am not an "awesome-c" committer. 2 problems I noticed:

  1. It is a good idea to target your pull-request at a feature-branch (rather than "master"/"main")
  2. The diff is too cluttered (changing the Table-of-Contents/etc.)

@daviduhden
Copy link
Author

daviduhden commented Jul 29, 2024

It is a good idea to target your pull-request at a feature-branch (rather than "master"/"main")

I don't consider it appropriate in this case.

The diff is too cluttered (changing the Table-of-Contents/etc.)

I have already fixed it, my IDE updated the table automatically and I didn't realize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants