Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in version parsing #78

Closed
chrsch-dev opened this issue Sep 5, 2024 · 2 comments
Closed

Possible regression in version parsing #78

chrsch-dev opened this issue Sep 5, 2024 · 2 comments
Labels
question Further information is requested

Comments

@chrsch-dev
Copy link

Hi,

since version 2.0.0 the behavior of the parsing of a purl did change:
For version <=1.2.0

PackageURL.fromString('pkg:npm/a@2%2B3').toString() produced `pkg:npm/a@2%2B3`

Since version 2.0.0 the output changed

PackageURL.fromString('pkg:npm/a@2%2B3').toString() produced `pkg:npm/a@2+3`

Was this change done by intention or is this a regression?

@chrsch-dev
Copy link
Author

See also #57 for problems with version parsing in the past

@jdalton
Copy link
Collaborator

jdalton commented Sep 8, 2024

@chrsch-dev This is related to #52 and #54 as well. The + is allowed in things like query params. The purl spec is about a balance of human readable encoding and percent encoding. Refs:

@jdalton jdalton added the question Further information is requested label Sep 8, 2024
@jdalton jdalton closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants