-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter case for npm packages #136
Comments
By convention, npm is lowercase. The spec states the name SHOULD be lowercased, but it doesn't state that it MUST be lowercased. I do think we need clarity here though. This issue was recently discovered in the official Package URL Java implementation and has subsequently been corrected. package-url/packageurl-java#38 There may be other implementations also affected. |
Hi @stevespringett , thanks for answering this, it's clearer now.
I guess it's a typo there and the ending was supposed to say "therefore the package must be lowercased" ? |
@scanossmining re:
Yes, good catch! PR welcomed! |
From the npm documentation:
The use of the word "New" on the third rule implies that this doesn't apply to existing packages. Since we want purls to be able to reference "new" and "old" packages that means we'd need to support mixed-case. The case should match the case used in the package's |
Sorry for reviving an old thread, but you are correct that there are older packages with names not following current rules. I will expand on this to say that while I agree with some of the apparent goals of this project, you are going to have a really tough time trying to get adoption in the JS ecosystem because you chose to break from the existing well understood and widely deployed formats. Honestly looking at the work in this repo, it looks like y'all skipped the step of asking folks who work on the JS package managers what they think. Not sure if y'all are too far along here to make a change in direction, but I would guess based on this issue that if you want a standard which is used by the npm registry that you will really need to re-assess the current proposal. |
Hello,
According to the specifications for the npm purl type, the package name inside the purl should be lowercased, however this would trigger some purl duplication. npmjs.com hosts case sensitive packages, some examples being:
The text was updated successfully, but these errors were encountered: