Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nuget case sensitivity #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion PURL-TYPES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,13 @@ nuget
- The default repository is ``https://www.nuget.org``.
- There is no ``namespace`` per se even if the common convention is to use
dot-separated package names where the first segment is ``namespace``-like.
- The ``name`` is the package ID. It is not case sensitive and must be
lowercased.
- Examples::

pkg:nuget/[email protected]
pkg:nuget/[email protected]
pkg:nuget/[email protected]
pkg:nuget/[email protected]

qpkg
----
Expand Down
30 changes: 27 additions & 3 deletions test-suite-data.json
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,41 @@
"is_invalid": false
},
{
"description": "nuget names are case sensitive",
"description": "nuget names are not case sensitive",
"purl": "pkg:Nuget/[email protected]",
"canonical_purl": "pkg:nuget/EnterpriseLibrary.Common@6.0.1304",
"canonical_purl": "pkg:nuget/enterpriselibrary.common@6.0.1304",
"type": "nuget",
"namespace": null,
"name": "EnterpriseLibrary.Common",
"name": "enterpriselibrary.common",
"version": "6.0.1304",
"qualifiers": null,
"subpath": null,
"is_invalid": false
},
{
"description": "nuget names do not always contain separators",
"purl": "pkg:nuget/[email protected]",
"canonical_purl": "pkg:nuget/[email protected]",
"type": "nuget",
"namespace": null,
"name": "polly",
"version": "8.0.0-beta.2",
"qualifiers": null,
"subpath": null,
"is_invalid": false
},
{
"description": "nuget versions are extended semver",
"purl": "pkg:Nuget/[email protected]",
"canonical_purl": "pkg:nuget/[email protected]",
"type": "nuget",
"namespace": null,
"name": "awssdk.core",
"version": "3.7.303.14",
"qualifiers": null,
"subpath": null,
"is_invalid": false
},
{
"description": "pypi names have special rules and not case sensitive",
"purl": "pkg:PYPI/[email protected]",
Expand Down