You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have an edge case where I'm looking for aria-expanded attributes to determine if there are popovers open while inside of a dialog.
In these cases I handle the escape key to close the popover and not the dialog.
This works fantastic when I render CMDK inside a combobox like shadcn combobox.
But when I use CMDK (Command in Shadcn) inline directly inside a modal my escape key functionality is not workin as expected because aria-expanded is set to true on the input.
This seems a little strange to me as the control is rendered in line and is not actually "expanded".
I realize this must be an incredibly arcane and strange edge case, but I'm curious to know why the decision was made to make aria-expanded true regardless of any expanded context or control?
And also... would you be open to make this property available to be over-ridden via props? 😊
Willing to contribute here if needed!
The text was updated successfully, but these errors were encountered:
Hello! Love your project!
what is the purpose of aria-expanded on the input?
cmdk/cmdk/src/index.tsx
Line 808 in 92344c5
I have an edge case where I'm looking for aria-expanded attributes to determine if there are popovers open while inside of a dialog.
In these cases I handle the escape key to close the popover and not the dialog.
This works fantastic when I render CMDK inside a combobox like shadcn combobox.
But when I use CMDK (Command in Shadcn) inline directly inside a modal my escape key functionality is not workin as expected because aria-expanded is set to true on the input.
This seems a little strange to me as the control is rendered in line and is not actually "expanded".
I realize this must be an incredibly arcane and strange edge case, but I'm curious to know why the decision was made to make aria-expanded true regardless of any expanded context or control?
And also... would you be open to make this property available to be over-ridden via props? 😊
Willing to contribute here if needed!
The text was updated successfully, but these errors were encountered: