Upgrade Django skeleton #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittner
force-pushed
the
feature/upgrade-django-skeleton
branch
from
1d03394
to
175b5cb
Compare
|
Failing tests and infrastructure issues are related to #29 and will be fixed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skeleton upgrade for Django further pushes Python 3. Django version 1.11 LTS is the only version officially supported by the Django project that still runs on Python 2 (officially).
urlsmodule, which uses apathfunction instead ofurlsince Django 2.0.envis not Django-specific we need to ignore that explicitly in thesettings.pep8is now calledpycodestyle(on request of Guido van Rossum in 2016), and unfortunately version 2.4 is incompatible with the latestflake8but nonetheless gets installed for some reason. We need to specify that in thetox.iniof the generator.