Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regenerate interface code on thrift 0.17.0 #577

Open
wants to merge 3 commits into
base: palantir-cassandra-2.2.18
Choose a base branch
from
Open

regenerate interface code on thrift 0.17.0 #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41e7022
manual updates to thrift generation
tpetracca Nov 8, 2024
3135104
re-gen thrift on 0.17.0
tpetracca Nov 8, 2024
0c57e05
Merge branch 'palantir-cassandra-2.2.18' into tp/codegen-thrift-0.17.0
rhuffy Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@
description="Generate Thrift Java artifacts">
<echo>Generating Thrift Java code from ${basedir}/interface/cassandra.thrift...</echo>
<exec executable="thrift" dir="${basedir}/interface" failonerror="true">
<arg line="--gen java:hashcode" />
<arg line="--gen java" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument was removed in 0.9.2 for THRIFT-2263 via apache/thrift@acdac81

Before 0.9.2 thrift's java impl did not generate equals() and hashcode() methods for classes by default unless the hashcode flag was set. As of 0.9.2 those methods are generated by default.

<arg line="-o ${interface.thrift.dir}" />
<arg line="cassandra.thrift" />
</exec>
Expand Down
1 change: 0 additions & 1 deletion interface/cassandra.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

namespace java org.apache.cassandra.thrift
namespace cpp org.apache.cassandra
namespace csharp Apache.Cassandra
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The csharp generator was deprecated in thrift 0.13.0 and removed in 0.14.0. We don't have any C# cassandra thrift clients, so it doesn't matter.

namespace py cassandra
namespace php cassandra
namespace perl Cassandra
Expand Down
163 changes: 67 additions & 96 deletions interface/thrift/gen-java/org/apache/cassandra/thrift/AuthenticationException.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading