Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in rules from tslint-microsoft-contrib #202

Closed
JoshuaKGoldberg opened this issue Feb 9, 2019 · 3 comments
Closed

Pull in rules from tslint-microsoft-contrib #202

JoshuaKGoldberg opened this issue Feb 9, 2019 · 3 comments

Comments

@JoshuaKGoldberg
Copy link

tslint-microsoft-contrib has several React-related rules, particularly around accessibility, that really belong in this repository:

  • react-a11y-accessible-headings
  • react-a11y-iframes
  • react-a11y-anchors
  • react-a11y-aria-unsupported-elements
  • react-a11y-event-has-role
  • react-a11y-image-button-has-alt
  • react-a11y-img-has-alt
  • react-a11y-input-elements
  • react-a11y-lang
  • react-a11y-meta
  • react-a11y-no-onchange
  • react-a11y-props
  • react-a11y-proptypes
  • react-a11y-required
  • react-a11y-role-has-required-aria-props
  • react-a11y-role-supports-aria-props
  • react-a11y-role
  • react-a11y-tabindex-no-positive
  • react-a11y-titles
  • react-anchor-blank-noopener
  • react-iframe-missing-sandbox
  • react-no-dangerous-html
  • react-this-binding-issue
  • react-tsx-curly-spacing
  • react-unused-props-and-state

Would you accept PRs to move them here? Are there preferences around this?

@adidahiya
Copy link
Contributor

adidahiya commented Mar 12, 2019

Is there a downside to leaving them where they are now?

edit: is it primarily about discoverability? I don't think moving them here for the purpose of giving them more "authority" would help, as this repo hasn't been maintained well over the past 6 months

@JoshuaKGoldberg
Copy link
Author

I believe it's been a point of confusion for users that there are two popular contributed rulesets with React-specific rules. Prior to the TSLint deprecation plans and this repository being somewhat unmaintained, it would have been nice to better delineate which rules go where.

At this point, I'm ok with taking no action.

@adidahiya
Copy link
Contributor

Closing due to deprecation timeline, see #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants