Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project dependency or styleguide dependency? #21

Open
labbydev opened this issue Apr 7, 2016 · 2 comments
Open

Project dependency or styleguide dependency? #21

labbydev opened this issue Apr 7, 2016 · 2 comments

Comments

@labbydev
Copy link
Contributor

labbydev commented Apr 7, 2016

Right now Butler assumes that it is the dependency of a project that has a styleguide. This means that the package.json and the node_modules are in the project root, but maybe that assumption is incorrect. Should it really be considered a styleguide dependency where those things would live in [project]/styleguide/ instead of inside [project]?

@labbydev
Copy link
Contributor Author

labbydev commented Apr 7, 2016

@becw I believe you and or the-build have thoughts on this

@becw
Copy link
Member

becw commented Apr 7, 2016

I do have thoughts on this, and so does my little baby AI, the-build.

Currently the-build is based on old butler, and installs all of the fed dependencies within the styleguide directory. It doesn't have to do this... I think I'll need to look at the MCor PR more in-depth before I can provide more thoughts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants