Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide deploy missing timestamp #58

Open
zendoodles opened this issue Sep 20, 2016 · 0 comments
Open

Styleguide deploy missing timestamp #58

zendoodles opened this issue Sep 20, 2016 · 0 comments

Comments

@zendoodles
Copy link
Contributor

Seems likely [timestamp] should actually be a timestamp, but when butler deploys to github pages, the commit message is always:
Updated with Butler - [timestamp]

While we're in that area of the code, it would also be handy to have the commit hash and message of the branch the deploy is working from. You can get this with git log -1 --format="[%ai] %h: %s" So if we were deploying from here:

commit d23a45909d32aec3caade7a73b7e26725860e42c
Author: Amazing Designer <[email protected]>
Date:   Tue Sep 13 14:28:49 2016 -0500

    create breadcrumb component

The commit message would be:
Updated with Butler - [2016-09-13 14:28:49 -0500] d23a459: create breadcrumb component

This suggestion means we get the timestamp of the recent commit, and not the timestamp of the commit which triggers the deployment, but the timestamp of the commit triggering the deployment is already in the commit. If we have the commit log, we probably already have that timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant