Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping modules from the skeleton #137

Open
byrond opened this issue Jan 9, 2023 · 1 comment
Open

Consider dropping modules from the skeleton #137

byrond opened this issue Jan 9, 2023 · 1 comment
Assignees
@becw
Labels
question

Comments

@byrond
Copy link
Contributor

byrond commented Jan 9, 2023 •
edited
Loading

The composer.json file for this skeleton includes some contributed Drupal modules:

drupal-skeleton/composer.json

Line 25 in 7f6aacc

"drupal/workbench_tabs": "^1.5",

These get installed by the-build during drupal-first-install here:
https://github.com/palantirnet/the-build/blob/0aefb99e0b04f53c292b8afaff8992c6f558d756/targets/drupal.xml#L275-L281

Given that, do we need them in the skeleton's composer.json, or can they be removed? This would prevent us from needing to maintain the versions of those modules in the skeleton, as the latest and most appropriate versions would be determine at project creation time.
@byrond byrond assigned byrond and becw and unassigned byrond Jan 9, 2023
@byrond byrond added the question label Jan 9, 2023
@byrond
Copy link
Contributor Author

byrond commented Jan 9, 2023

Testing this on #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@becw becw

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@becw @byrond