From 1f7450e4eeaa56d1df768dd8daa77febf9801b7c Mon Sep 17 00:00:00 2001 From: jaymejohnson Date: Tue, 9 Jan 2024 11:55:17 -0500 Subject: [PATCH 1/5] DEV-49: Add behat features directory to phpcs linting. --- defaults/install/phpcs.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/defaults/install/phpcs.xml b/defaults/install/phpcs.xml index cacd6a09..93792117 100644 --- a/defaults/install/phpcs.xml +++ b/defaults/install/phpcs.xml @@ -31,6 +31,7 @@ @webroot@/modules/custom @webroot@/themes/custom + @webroot@/features/bootstrap */behat */node_modules From 03679d624116324c843981214f4caca812daa5bf Mon Sep 17 00:00:00 2001 From: jaymejohnson Date: Tue, 9 Jan 2024 14:18:38 -0500 Subject: [PATCH 2/5] We need to create directories for our custom behat code and to collect screenshots from failed tests. --- defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults.yml b/defaults.yml index b56e2fdc..957f06ee 100644 --- a/defaults.yml +++ b/defaults.yml @@ -24,7 +24,7 @@ drupal: #root: web # Comma-separated list of directories that should be present for Drupal development. - create_dirs: "${drupal.root}/modules/custom,${drupal.root}/themes/custom,config/config_split/development,config/config_split/staging,config/config_split/production" + create_dirs: "${drupal.root}/modules/custom,${drupal.root}/themes/custom,config/config_split/development,config/config_split/staging,config/config_split/production,features/bootsrap,features/screenshots" twig: # Whether to enable twig debugging. From 237e69d2284d1abddd6199892e9c48f9718472c8 Mon Sep 17 00:00:00 2001 From: jaymejohnson Date: Tue, 9 Jan 2024 14:22:15 -0500 Subject: [PATCH 3/5] Remove webroot from features file path so it's pointing to the correct path. --- defaults/install/phpcs.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/phpcs.xml b/defaults/install/phpcs.xml index 93792117..eb0acf11 100644 --- a/defaults/install/phpcs.xml +++ b/defaults/install/phpcs.xml @@ -31,7 +31,7 @@ @webroot@/modules/custom @webroot@/themes/custom - @webroot@/features/bootstrap + /features/bootstrap */behat */node_modules From fb8376efd651d6f6ba74cfc34a2790260bdc4bd3 Mon Sep 17 00:00:00 2001 From: jaymejohnson Date: Tue, 9 Jan 2024 14:28:27 -0500 Subject: [PATCH 4/5] Fix path syntax on phpcs. --- defaults/install/phpcs.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/phpcs.xml b/defaults/install/phpcs.xml index eb0acf11..1d953a46 100644 --- a/defaults/install/phpcs.xml +++ b/defaults/install/phpcs.xml @@ -31,7 +31,7 @@ @webroot@/modules/custom @webroot@/themes/custom - /features/bootstrap + features/bootstrap */behat */node_modules From 529824f9a851d1e43c89e4b8b947e5b49dda796f Mon Sep 17 00:00:00 2001 From: jaymejohnson Date: Tue, 9 Jan 2024 15:04:04 -0500 Subject: [PATCH 5/5] Remove mkdir for features/bootstrap. --- defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults.yml b/defaults.yml index 957f06ee..c0add94b 100644 --- a/defaults.yml +++ b/defaults.yml @@ -24,7 +24,7 @@ drupal: #root: web # Comma-separated list of directories that should be present for Drupal development. - create_dirs: "${drupal.root}/modules/custom,${drupal.root}/themes/custom,config/config_split/development,config/config_split/staging,config/config_split/production,features/bootsrap,features/screenshots" + create_dirs: "${drupal.root}/modules/custom,${drupal.root}/themes/custom,config/config_split/development,config/config_split/staging,config/config_split/production,features/screenshots" twig: # Whether to enable twig debugging.