From aaee92a18a885de4c0ef4182042de1a4f9bfe67f Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:34:16 -0400 Subject: [PATCH 1/7] Update to Node 18 on CircleCI --- defaults/install/.circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/.circleci/config.yml b/defaults/install/.circleci/config.yml index 7b10a859..20ecf63a 100644 --- a/defaults/install/.circleci/config.yml +++ b/defaults/install/.circleci/config.yml @@ -20,7 +20,7 @@ jobs: environment: - PALANTIR_ENVIRONMENT: circleci - DRUPAL_ROOT: ${drupal.root} - - NODE_VERSION: 8 + - NODE_VERSION: 18 steps: - run: From 8c5ebb3da4761a6c8094efbd9903192c11e9c6e7 Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:36:26 -0400 Subject: [PATCH 2/7] Update deploy-pantheon.example circleci config to use node 18 --- defaults/install/.circleci/deploy-pantheon.example | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/.circleci/deploy-pantheon.example b/defaults/install/.circleci/deploy-pantheon.example index 544f0073..2d68fbeb 100644 --- a/defaults/install/.circleci/deploy-pantheon.example +++ b/defaults/install/.circleci/deploy-pantheon.example @@ -26,7 +26,7 @@ docker: - image: cimg/php:8.1-browsers environment: - - NODE_VERSION: 8 + - NODE_VERSION: 18 - GITHUB_PUBKEY: "github.com,192.30.253.113 ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==" - PANTHEON_PUBKEY: "[codeserver.dev.56f20816-b4b7-4517-a90f-667b4785708d.drush.in]:2222,[35.193.151.123]:2222 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSY3gnr0DrbqJJSnEFy6jazDmAdBm4Zs/EkWIQa7x31qgSYyYJMz5V+pk62lBf2BN42VtubwO83vW9G+yG2K1RGOvZJaK5GBvBb/Ws2ZPcp/4sNHpPzkdd75e5/Pk8AWA59XUbJcBWmrDrHMbWV1j2zqPPikxbqGeTTjSx4QR18LIRei5OwT6VQnaVnJqPAqFZ+oCbpr0DL96foL3UEY8EWT/6GH2cANEGZO4ppbhdDw4uG6TaI7S0lxWMQEVy+iwjCNH/nanjd73cwoYd90E0OVdgNDr3hVbIuE6sUW6UwlaAwuyOM/xJYPg1y0rF66958pyVJlZ9KD5A0kY3bHg7" From 591c7f046f607f3d2b0070a5440bd72b02c1b11b Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:37:04 -0400 Subject: [PATCH 3/7] Update deploy-acquia-example circleci config to use node 18 --- defaults/install/.circleci/deploy-acquia-example | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/.circleci/deploy-acquia-example b/defaults/install/.circleci/deploy-acquia-example index aab77b5a..b0da9a82 100644 --- a/defaults/install/.circleci/deploy-acquia-example +++ b/defaults/install/.circleci/deploy-acquia-example @@ -23,7 +23,7 @@ docker: - image: cimg/php:8.1-browsers environment: - - NODE_VERSION: 8 + - NODE_VERSION: 18 - GITHUB_PUBKEY: "github.com,192.30.253.113 ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==" - ACQUIA_PUBKEY: "svn-23450.prod.hosting.acquia.com,54.245.120.237 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDit0Rj8j59i9Gj2vOg2TXjIbPswIc27PwncapyBLi9R3FtECXq+md1BfykBJjME83m78CtqkTlWwNZu+LyhF+IYlshKo82JXQzV4kWwi5L9H7KpdyFDMDLVCNVYmU4EQY9ngRq1cwbMBYsfWxv4sSlbsvZv2C8U7luNoc4SiBY4sGpgiMJLFOHWRw6YvhOamLTKfxSoJUT8uRbfkamxas1EK21XjvrdUSN0Bf5LmTdvs/9iIaUH4AlYr0SW0tc2IbIuoFVxuvSzZj2GJjmtCcW1poDMQLTGq+EuO4Mk1WyoUSJC9L8CFonKH7++EPHopvIbPMinO4r2zLEot3lL5TH" From a260fca4145ff50e24dc8ec52bb8c4c8d2bdfa81 Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:39:57 -0400 Subject: [PATCH 4/7] use php 8.2 on circleci --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 5ac76ad2..d3c25815 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ jobs: build: working_directory: ~/project docker: - - image: cimg/php:8.1-browsers + - image: cimg/php:8.2-browsers - image: cimg/mysql:5.7 command: --max_allowed_packet=16M environment: From 63fd8e2b0c6f8826598df99b6b9c6dc099c8362d Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:40:49 -0400 Subject: [PATCH 5/7] Update default installed config.yml to use php 8.2 --- defaults/install/.circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/install/.circleci/config.yml b/defaults/install/.circleci/config.yml index 20ecf63a..0f0dc9f9 100644 --- a/defaults/install/.circleci/config.yml +++ b/defaults/install/.circleci/config.yml @@ -9,7 +9,7 @@ jobs: build: working_directory: ~/${projectname} docker: - - image: cimg/php:8.1-browsers + - image: cimg/php:8.2-browsers - image: cimg/mysql:5.7 command: --max_allowed_packet=16M environment: From 0c0039b8d30411f1141cae85b961fca0b88b82b1 Mon Sep 17 00:00:00 2001 From: byrond Date: Fri, 26 May 2023 13:43:25 -0400 Subject: [PATCH 6/7] add phpcs known issue to readme --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index e5564a42..55ec6db8 100644 --- a/README.md +++ b/README.md @@ -65,6 +65,10 @@ View a list of other available targets with: $> vendor/bin/phing -l ``` +## Known Issues + +When using `phpcs` with PHP 8.1.19, there is a memory leak that will cause the process to hang. It will be killed on CircleCI, and jobs will fail. Pin the container to version 8.1.18 to work around this issue. + ## Additional documentation * [Configuring the-build](docs/configuration.md) From d4a2332b3c60286850915348153cbe19b13f9295 Mon Sep 17 00:00:00 2001 From: byrond Date: Wed, 29 May 2024 16:16:18 -0400 Subject: [PATCH 7/7] remove PHP 8.1 known issue from readme --- README.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/README.md b/README.md index 55ec6db8..e5564a42 100644 --- a/README.md +++ b/README.md @@ -65,10 +65,6 @@ View a list of other available targets with: $> vendor/bin/phing -l ``` -## Known Issues - -When using `phpcs` with PHP 8.1.19, there is a memory leak that will cause the process to hang. It will be killed on CircleCI, and jobs will fail. Pin the container to version 8.1.18 to work around this issue. - ## Additional documentation * [Configuring the-build](docs/configuration.md)