From 3035b9dbf78ac42b6973b1fd678a65caa3482c62 Mon Sep 17 00:00:00 2001
From: Byron Duvall <duvall@palantir.net>
Date: Thu, 22 Aug 2024 09:43:44 -0400
Subject: [PATCH 1/6] remove core node package installation step

---
 defaults/install/build.xml | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/defaults/install/build.xml b/defaults/install/build.xml
index 4f305052..a13abe3a 100644
--- a/defaults/install/build.xml
+++ b/defaults/install/build.xml
@@ -173,17 +173,6 @@
                 <exec dir="${drupal.root}/.." command="yarn install" logoutput="true" />
             </then>
         </if>
-        <echo msg="Seeing if Drupal core npm packages are installed and at the expected version." />
-        <exec dir="${drupal.root}/core" command="yarn install --check-files --verbose" returnProperty="core_dependencies"  logoutput="true" />
-        <if>
-            <not>
-                <equals arg1="${core_dependencies}" arg2="0" />
-            </not>
-            <then>
-                <echo msg="Install Core node dependencies to get eslint libraries." />
-                <exec dir="${drupal.root}/core" command="yarn install" logoutput="true" checkreturn="true" />
-            </then>
-        </if>
     </target>
 
 

From 23aa0f5c41635ec2366dc67ea2f81d158262fde2 Mon Sep 17 00:00:00 2001
From: Byron Duvall <duvall@palantir.net>
Date: Thu, 22 Aug 2024 09:46:05 -0400
Subject: [PATCH 2/6] remove explicit yarn package installation check since
 yarn already does this

---
 defaults/install/build.xml | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/defaults/install/build.xml b/defaults/install/build.xml
index a13abe3a..bef28a27 100644
--- a/defaults/install/build.xml
+++ b/defaults/install/build.xml
@@ -162,17 +162,8 @@
 
     <!-- Target: install-node-dependencies -->
     <target name="install-node-dependencies" depends="" description="Install project, core, and custom module node dependencies">
-        <echo msg="Seeing if project npm packages are installed and at the expected version." />
-        <exec command="yarn install --check-files --verbose" returnProperty="project_dependencies"  logoutput="true" />
-        <if>
-            <not>
-                <equals arg1="${project_dependencies}" arg2="0" />
-            </not>
-            <then>
-                <echo msg="Install project node dependencies to get eslint libraries." />
-                <exec dir="${drupal.root}/.." command="yarn install" logoutput="true" />
-            </then>
-        </if>
+        <echo msg="Install project node dependencies to get eslint libraries." />
+        <exec dir="${drupal.root}/.." command="yarn install" logoutput="true" />
     </target>
 
 

From f938f89971fb793a10d736841f8fda7040a85787 Mon Sep 17 00:00:00 2001
From: Byron Duvall <duvall@palantir.net>
Date: Thu, 22 Aug 2024 16:36:58 -0400
Subject: [PATCH 3/6] test this branch with its skeleton counterpart

---
 .circleci/config.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 2dcee84a..6102eaa7 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -72,7 +72,7 @@ jobs:
       # Create a new project using the drupal-skeleton project
       - run:
           name: Create a new Drupal project
-          command: composer create-project palantirnet/drupal-skeleton example dev-develop --no-interaction
+          command: composer create-project palantirnet/drupal-skeleton example dev-DEV-70-update-install-node-dependencies-task-in-the-build --no-interaction
           working_directory: ~/
 
       # Use this copy of the-build

From 1efbb57549b4c42da4b818ee92031390033b0f33 Mon Sep 17 00:00:00 2001
From: Byron Duvall <duvall@palantir.net>
Date: Fri, 23 Aug 2024 09:44:50 -0400
Subject: [PATCH 4/6] remove --resolve-plugins-relative-to drupal core option

---
 defaults/install/build.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/defaults/install/build.xml b/defaults/install/build.xml
index bef28a27..cdb6ca2c 100644
--- a/defaults/install/build.xml
+++ b/defaults/install/build.xml
@@ -149,7 +149,7 @@
     <target name="eslint" depends="install-node-dependencies">
         <!-- Lint custom module and theme (by default) javascript. -->
         <echo msg="$> yarn run eslint --ext ${eslint.extensions} ${eslint.directory}" />
-        <exec command="yarn run eslint --fix-dry-run --ext ${eslint.extensions} --resolve-plugins-relative-to ${drupal.root}/core --no-error-on-unmatched-pattern ${eslint.directory}" logoutput="true" checkreturn="true" />
+        <exec command="yarn run eslint --fix-dry-run --ext ${eslint.extensions} --no-error-on-unmatched-pattern ${eslint.directory}" logoutput="true" checkreturn="true" />
     </target>
 
 

From 29902fd7d839b22f4425d7ff171004806c23d4a5 Mon Sep 17 00:00:00 2001
From: Byron Duvall <duvall@palantir.net>
Date: Fri, 23 Aug 2024 13:04:23 -0400
Subject: [PATCH 5/6] revert change to circle config composer create-project
 step

---
 .circleci/config.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 6102eaa7..2dcee84a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -72,7 +72,7 @@ jobs:
       # Create a new project using the drupal-skeleton project
       - run:
           name: Create a new Drupal project
-          command: composer create-project palantirnet/drupal-skeleton example dev-DEV-70-update-install-node-dependencies-task-in-the-build --no-interaction
+          command: composer create-project palantirnet/drupal-skeleton example dev-develop --no-interaction
           working_directory: ~/
 
       # Use this copy of the-build

From fa0906c36b47e89ba96fe18fdf0412b0f13c71d5 Mon Sep 17 00:00:00 2001
From: Bec White <white@palantir.net>
Date: Mon, 26 Aug 2024 14:18:34 -0500
Subject: [PATCH 6/6] Update default CircleCI config to cache packages used by
 both composer and yarn.

---
 defaults/install/.circleci/config.yml | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/defaults/install/.circleci/config.yml b/defaults/install/.circleci/config.yml
index 9d7ffc57..64267d6f 100644
--- a/defaults/install/.circleci/config.yml
+++ b/defaults/install/.circleci/config.yml
@@ -50,10 +50,11 @@ jobs:
           name: Configure URL in /etc/hosts
           command: echo 127.0.0.1 ${CIRCLE_PROJECT_REPONAME}.local | sudo tee -a /etc/hosts
 
-      # Composer package cache
+      # Package cache
       - restore_cache:
           keys:
-            - composer-v1-
+            - package-cache-v1-
+
       # Source cache
       - restore_cache:
           keys:
@@ -64,15 +65,19 @@ jobs:
       - run:
           name: Composer install
           command: composer install --no-interaction --prefer-dist
+      - run:
+          name: Yarn install
+          command: yarn install
 
-      # Composer package cache - update when the contents of the Composer cache directory
-      # change
-      - run: ls -1R ~/.cache/composer/ > /tmp/composer-cache.txt
+      # Package cache. This is updated when the contents of the ~/.cache directory change.
+      # Both Composer and Yarn use this directory.
+      - run: ls -1R ~/.cache/ > /tmp/package-cache.txt
       - save_cache:
-          key: composer-v1-{{ checksum "/tmp/composer-cache.txt" }}
+          key: package-cache-v1-{{ checksum "/tmp/package-cache.txt" }}
           paths:
-              - ~/.cache/composer
-      # Source cache - update when branch changes
+              - ~/.cache
+
+      # Source cache. This is updated for each different branch.
       - save_cache:
           key: source-v1-{{ .Branch }}
           paths: