Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about not tracking dist in VCS? #481

Closed
mightyiam opened this issue Nov 14, 2019 · 3 comments · Fixed by #549
Closed

How about not tracking dist in VCS? #481

mightyiam opened this issue Nov 14, 2019 · 3 comments · Fixed by #549
Labels
affects:developer only type:bug

Comments

@mightyiam
Copy link
Contributor

I feel against tracking build artifacts in VCS.
@mightyiam mightyiam mentioned this issue Nov 14, 2019
Closed
@mightyiam mightyiam mentioned this issue Dec 12, 2019
Closed
@mreinstein
Copy link
Contributor

prepublishOnly npm event is probably the right place to generate the dist directory

mightyiam added a commit that referenced this issue Dec 20, 2019
@mightyiam
chore: deprecate standalone UMD bundles
435d7ea 
The standalone UMD bundles provided in the npm package under `dist` will
no longer be updated. They are already several commits behind. See issue

Closes #498. Closes #514. Closes #481.
@mightyiam mightyiam mentioned this issue Dec 20, 2019
Closed
mightyiam added a commit that referenced this issue Jan 7, 2020
@mightyiam
chore: deprecate standalone UMD bundles
f503c0a 
The standalone UMD bundles provided in the npm package under `dist` will
no longer be updated. They are already several commits behind. See issue

Closes #498. Closes #514. Closes #481.
mightyiam added a commit that referenced this issue Jan 7, 2020
@mightyiam
chore: deprecate standalone UMD bundles
7dbcdcf 
The standalone UMD bundles provided in the npm package under `dist` will
no longer be updated. They are already several commits behind. See issue

Closes #498. Closes #514. Closes #481.
mightyiam added a commit that referenced this issue Jan 15, 2020
@mightyiam
chore: deprecate standalone UMD bundles
a81119b 
The standalone UMD bundles provided in the npm package under `dist` will
no longer be updated. They are already several commits behind. See issue

Closes #498. Closes #514. Closes #481.
mightyiam added a commit that referenced this issue Jan 16, 2020
@mightyiam
chore: do not provide UMD bundles
ee97a2e 
BREAKING CHANGE: UMD bundles are no longer provided.

Closes #498. Closes #514. Closes #481.
@mightyiam mightyiam mentioned this issue Jan 16, 2020
Merged
mightyiam added a commit that referenced this issue Jan 16, 2020
@mightyiam
chore: do not provide UMD bundles
f12e4d0 
BREAKING CHANGE: UMD bundles are no longer provided.

Closes #498. Closes #514. Closes #481.
@kuraga
Copy link

kuraga commented Jan 18, 2020

IMHO type:bug -> type:enhancement should be relabeled...

@mreinstein
Copy link
Contributor

depends on how you define an enhancement. This particular task is probably not much more work than would be required to adjust the labeling of it. :) Might be time better spent to just complete it.

@mreinstein mreinstein mentioned this issue Jan 22, 2020
Closed
mightyiam added a commit that referenced this issue Jan 22, 2020
@mightyiam
chore: do not provide UMD bundles
8e24bbf 
BREAKING CHANGE: UMD bundles are no longer provided.

Closes #498. Closes #514. Closes #481.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:developer only type:bug
Projects
None yet
Milestone
No milestone
3 participants
@mightyiam @mreinstein @kuraga