Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One connection per request? #4

Open
fengsp opened this issue Nov 16, 2013 · 3 comments
Open

One connection per request? #4

fengsp opened this issue Nov 16, 2013 · 3 comments

Comments

@fengsp
Copy link

fengsp commented Nov 16, 2013

I have noticed that flask-rq does not use context-locals to save the redis connection, which means that everytime one request comes in, we are having a new connection.

What I need here is one connection manager so I do not have to handle connections myself.

Any reasons? So flask-rq is just a config manager? I do not see anything else meaningful here.

@malthe
Copy link

malthe commented Aug 14, 2014

Indeed. This extension is not meaningful at all. I was about to submit a pull request that removes the custom connection behavior, but then realized that with that removed, there's virtually no code left.

@joostdevries
Copy link
Collaborator

@fengsp @malthe I agree with you that using an app context would make sense. I plan to get some work done on this the coming days/weeks. Out of curiosity: are you using flask-script?

@italomaia
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants