Skip to content

CSRF Vuln can expose user's QRcode

Low
jwag956 published GHSA-fxq4-r6mr-9x64 Jan 8, 2021

Package

Flask-Security (pypi)

Affected versions

3.2.0 - 3.4.4

Patched versions

4.0.0

Description

Impact

When a user is setting up two-factor authentication using an authenticator app, a QRcode is generated and made available via a GET request to /tf-qrcode. Since GETs do not have any CSRF protection, it is possible a malicious 3rd party could access the QRcode and therefore gain access to two-factor authentication codes. Note that the /tf-qrcode endpoint is ONLY accessible while the user is initially setting up their device. Once setup is complete, there is no vulnerability.

Patches

This is fixed in the upcoming 4.0.0 release.

Workarounds

You can provide your own URL for fetching the QRcode by defining SECURITY_TWO_FACTOR_QRCODE_URL and providing your own implementation (that presumably required a POST with CSRF protection). This would require changing the two-factor setup template as well.

References

None.

For more information

If you have any questions or comments about this advisory:

  • Read this pull request: #423

Severity

Low

CVE ID

No known CVE

Weaknesses

No CWEs