Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following typing issues existed before:
click.edit
text
argument acceptedbytearray
but was not included in the typing._termui_impl
None
was inputted,str
would be returned but typing suggested that it would bestr
ifstr
was given andbytes
ifbytes
was given.This resolved an
type: ignore
as well.Add tests that demonstrate the correct behavior of the change. Testsshould fail without the change.
Add or update relevant docs, in the docs folder and in code.Add an entry in CHANGES.rst summarizing the change and linking to the issue.bytearray
was always accepted, just not documented.Add.. versionchanged::
entries in any relevant code docs.