Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature of StringMethods.rsplit to match pandas #1056

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kroche98
Copy link
Contributor

This removes the nonexistent regex: bool parameter from the StringMethods.rsplit function.

I haven't added any tests, as it doesn't seem the parameter types of any string accessor methods are tested.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Nov 25, 2024

I haven't added any tests, as it doesn't seem the parameter types of any string accessor methods are tested.

We do have tests for str.rsplit() in test_series.py. Having said that, adding a test for an incorrect parameter isn't really needed.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kroche98

@Dr-Irv Dr-Irv merged commit c5eecf8 into pandas-dev:main Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect signature for pandas.Series.str.rsplit
2 participants