Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove PY2 compat code #32677

Merged

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Benchmarks:

Master:

In [1]: import pandas as pd                                                                                   

In [2]: s = pd.Series(list("ABCA"))                                                                           

In [3]: %timeit pd.get_dummies(s)                                                                             
482 µs ± 752 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)

PR:

In [1]: import pandas as pd                                                                                   

In [2]: s = pd.Series(list("ABCA"))                                                                           

In [3]: %timeit pd.get_dummies(s)                                                                             
479 µs ± 2.43 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

@topper-123 topper-123 added this to the 1.1 milestone Mar 13, 2020
@topper-123
Copy link
Contributor

LGTM.

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend lgtm. can merge when all ci envs run.

@topper-123 topper-123 merged commit 059f9bf into pandas-dev:master Mar 13, 2020
@topper-123
Copy link
Contributor

Thanks, @MomIsBestFriend.

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Mar 13, 2020
@ShaharNaveh ShaharNaveh deleted the CLN-remove-py2-compat-code branch March 14, 2020 14:07
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Co-authored-by: MomIsBestFriend <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants