Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Numpy 2.0 #373

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Compatibility with Numpy 2.0 #373

merged 2 commits into from
Jun 26, 2024

Conversation

aulemahal
Copy link
Collaborator

Fixes #370.

NaN -> nan

@aulemahal aulemahal requested review from huard and raphaeldussin June 25, 2024 17:28
@@ -202,11 +202,11 @@ def apply_weights(weights, indata, shape_in, shape_out):


def add_nans_to_weights(weights):
"""Add NaN in empty rows of the regridding weights sparse matrix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to change the comments as well. I don't really case either way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I did and then I decided I did not care enough to change the comments in the other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: np.NaN was removed in the NumPy 2.0 release. Use np.nan instead.
2 participants