Add env replacer based on VisitMut #9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is aimed at improving moving SWC usage to visit for all parcel use-cases as we are facing memory errors due to stack-overflow. Errors include segmentation faults and bus errors. This is part of #9828. Adds exhaustive tests for the folder. The next commit will remove the fold implementation and demonstrate tests pass for the visit implementation as well. The following behaviours of the fold implementation should be revised in the future as they likely are unwanted: * `process.browser = ...` assignment expressions are replaced with `process.browser = true`, which is not a safe replacement * expression replacements `const x = ({ x } = process.env);` are supported but insert an extra trailing object `const x = (x = 'asdf', {}); * when `replace_env` replacement is off the transformer still replaces several cases that aren't the base declarations case Overall could simplify this so that less cases are supported, and then shift it to be a generalised inline variable replacement implementation. Currently this implementation is quite large to handle things that aren't necessarily needed or wanted.
This replaces the Fold env replacer with a VisitMut implementation. All tests pass on this new version with no real change. A case was added for the `delete process.env.value` behaviour.
MonicaOlejniczak
approved these changes
Jul 17, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9828
This is aimed at improving moving SWC usage to visit for all parcel
use-cases as we are facing memory errors due to stack-overflow. Errors
include segmentation faults and bus errors.
This is part of #9828. Adds exhaustive tests for the folder.
Update transformer to use the VisitMut impl.
This replaces the Fold env replacer with a VisitMut implementation.
All tests pass on both old/new versions.
The following behaviours of the fold implementation should be revised in
the future as they might be unwanted:
process.browser = ...assignment expressions are replaced withprocess.browser = true, which is not a safe replacementconst x = ({ x } = process.env);aresupported but insert an extra trailing object `const x = (x = 'asdf', {});
replace_envreplacement is off the transformer still replacesseveral cases that aren't the base declarations case
Overall could simplify this so that less cases are supported, and then
shift it to be a generalised inline variable replacement implementation.