Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace-enabled example contracts (was PR:#44) #52

Merged
merged 17 commits into from
Nov 21, 2023

Conversation

tenuki
Copy link
Contributor

@tenuki tenuki commented Nov 14, 2023

This PR creates a workspace where dependencies are defined and several smart-contracts as part of the same workspace, with inherited dependencies.

We tried different strategies on how to run the workspace contracts' build, and we chosen to try that build as a "whole" analogous to a contract in the test matrix. The execution will be then cartesian product with the platforms.

Having the whole workspace-contracts in that way, we expect it to be all contracts in the workspace compiled at once.

We also included the suggestions given in the PR:44 before.

Was:

At the moment there are a few errors on cargo-contract preventing us to run it completely flawlessly, mainly : 
 * https://github.com/paritytech/cargo-contract/issues/1172
 * https://github.com/paritytech/cargo-contract/issues/1265
That is why we chosen to run the suggested build with `cargo build` instead. But left commented out what 
would be expected to be working in the future when above tickets get fixed.

Updated to:
Updated the CI/CD to what it should be: cargo contract build ... which will fail right now, but have no problems when the cargo-contract version is v 4.0 including: use-ink/cargo-contract#1358 .

@tenuki
Copy link
Contributor Author

tenuki commented Nov 15, 2023

Checked the actual code in the workspace examples and have no problems when ran with cargo-contract v 4.0.

@tenuki tenuki reopened this Nov 15, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Update ci.yml removed redundant configuration
@ascjones ascjones merged commit 33ecf5b into use-ink:main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants