-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workspace-enabled example contracts (was PR:#44) #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2023
Checked the actual code in the workspace examples and have no problems when ran with cargo-contract v 4.0. |
5 tasks
ascjones
approved these changes
Nov 21, 2023
Update ci.yml removed redundant configuration
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a workspace where dependencies are defined and several smart-contracts as part of the same workspace, with inherited dependencies.
We tried different strategies on how to run the workspace contracts' build, and we chosen to try that build as a "whole" analogous to a contract in the test matrix. The execution will be then cartesian product with the platforms.
Having the whole workspace-contracts in that way, we expect it to be all contracts in the workspace compiled at once.
We also included the suggestions given in the PR:44 before.
Was:
Updated to:
Updated the CI/CD to what it should be:
cargo contract build ...
which will fail right now, but have no problems when the cargo-contract version is v 4.0 including: use-ink/cargo-contract#1358 .