Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username and password in the url ignored #1371

Closed
dpc opened this issue May 19, 2024 · 1 comment · Fixed by #1384
Closed

Username and password in the url ignored #1371

dpc opened this issue May 19, 2024 · 1 comment · Fixed by #1384

Comments

@dpc
Copy link

dpc commented May 19, 2024

From my experiment and reading the code:

let mut target: Target = uri.try_into()?;

it seems that the username and passwords are simply ignored.

As a workaround, I am able to manually set Authorization header with set_headers and that works.

Thought it seems that wasm client does not support set_headers. Instead it seems to pass the url unmodified, so I suspect (haven't tested yet), the browser will handle user:pass@ just fine, making it all rather inconsistent.

@niklasad1
Copy link
Member

it seems that the username and passwords are simply ignored.

Correct, sure we can add that to be consistent with wasm client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants