Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/server]: replace async-channel with tokio::sync::watch in RpcModule #691

Closed
niklasad1 opened this issue Feb 4, 2022 · 1 comment · Fixed by #708
Closed

[core/server]: replace async-channel with tokio::sync::watch in RpcModule #691

niklasad1 opened this issue Feb 4, 2022 · 1 comment · Fixed by #708

Comments

@niklasad1
Copy link
Member

niklasad1 commented Feb 4, 2022 •
edited
Loading

We already depend heavily on tokio and it doesn't make sense to bring async-channel into the dependency tree just for this.
Tokio has similar primitives such as watch and broadcast
@niklasad1 niklasad1 changed the title [core]: RpcModule replace async-channel with tokio::sync::broadcast [core/server]: replace async-channel with tokio::sync::broadcast in RpcModule Feb 4, 2022
@niklasad1 niklasad1 changed the title [core/server]: replace async-channel with tokio::sync::broadcast in RpcModule [core/server]: replace async-channel with tokio::sync::watch in RpcModule Feb 9, 2022
@niklasad1
Copy link
Member Author

@dvdplm told me that tokio::sync::watch fit our use case better.

@dvdplm dvdplm mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace async-channel paritytech/jsonrpsee
1 participant
@niklasad1