Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clients]: unify APIs to configure custom headers #809

Closed
niklasad1 opened this issue Jun 26, 2022 · 0 comments · Fixed by #814
Closed

[clients]: unify APIs to configure custom headers #809

niklasad1 opened this issue Jun 26, 2022 · 0 comments · Fixed by #814
Assignees
@lexnv
Milestone
[public] v1.0 and...

Comments

@niklasad1
Copy link
Member

Currently the WS-client/async client has functionality to configure custom headers to send during the upgrade request/connection.

The HTTP client on the other hand doesn't have this functionality, see #756

So ideally we should have a unified API to fn set_headers(headers: &[Headers]) or something for that.
@niklasad1 niklasad1 added this to the v1.0 milestone Jun 26, 2022
@lexnv lexnv mentioned this issue Jul 5, 2022
Merged
1 task
@lexnv lexnv self-assigned this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexnv lexnv

Labels
None yet
Projects
None yet
Milestone
[public] v1.0 and move to maintenance
Development

Successfully merging a pull request may close this issue.

Uniform API for custom headers between clients paritytech/jsonrpsee
2 participants
@niklasad1 @lexnv