Documentation update for weight. #7354 #7376
Open
+55
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should be in the doc of |
That's what I meant to do |
bkchr
reviewed
Jan 29, 2025
substrate/frame/support/src/lib.rs
Outdated
Comment on lines
1115
to
1116
| /// # #[pallet::config] | ||
| /// # pub trait Config: frame_system::Config { |
There was a problem hiding this comment.
Suggested change
| /// # #[pallet::config] | |
| /// # pub trait Config: frame_system::Config { | |
| /// #[pallet::config] | |
| /// pub trait Config: frame_system::Config { |
| /// | ||
| /// #[pallet::call] | ||
| /// impl<T: Config> Pallet<T> { | ||
| /// #[pallet::weight({0})] // <- set actual weight here | ||
| /// #[pallet::weight(<T as Config>::WeightInfo::do_something())] |
There was a problem hiding this comment.
The issue was talking about the following syntax:
#[pallet::weight(<T as Config>::WeightInfo)]
But your example also makes sense! It would be nice if you could include both examples :)
There was a problem hiding this comment.
I already added examples using the #[pallet::weight(<T as Config>::WeightInfo)] or #[pallet::call(weight = <T as Config>::WeightInfo)] attribute. which examples do you mean, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7354