Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix release profile #4778

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Fix release profile #4778

merged 4 commits into from
Jan 25, 2022

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Jan 25, 2022 •
edited
Loading

Please note that this fix alone is not changing how builds will be produced as our internal build still builds --release and passes the LTO and codegen-units flags. I will however change our internal build to use the production profile for more transparency.

ref #4311

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 25, 2022
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 25, 2022
@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jan 25, 2022
This was referenced Jan 25, 2022
Closed
Merged
ordian
ordian reviewed Jan 25, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@ordian
Copy link
Member

ordian commented Jan 25, 2022

I didn't add codegen-units = 1 because of #4311 (comment). However, I don't think it hurts.

@ggwpez
Copy link
Member

ggwpez commented Jan 25, 2022

I didn't add codegen-units = 1 because of #4311 (comment). However, I don't think it hurts.

It does improve performance, I dont know how the comment came to that conclusion.
wasmi-labs/wasmi#339 and https://github.com/ggwpez/substrate-bench/tree/master/reports/01-first-findings checked it in detail.

ggwpez
ggwpez approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bench bot now also uses the production profile. So if you are paranoid about that it works, you could start it and then revert the commit.

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Jan 25, 2022
@chevdor
Copy link
Contributor Author

chevdor commented Jan 25, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit ff9de67 into master Jan 25, 2022
@paritytech-processbot paritytech-processbot bot deleted the wk-fix-build-profiles branch January 25, 2022 15:19
ordian added a commit that referenced this pull request Jan 27, 2022
@ordian
Merge branch 'master' into refactor_check_validation_outputs
675dde3 
* master:
  Fix incomplete sorting. (#4795)
  Companion for better way to resolve `Phase::Emergency` via governance #10663 (#4757)
  Refactor and fix usage of `get_session_index()` and `get_session_info_by_index()` (#4735)
  `relay chain selection` and `dispute-coordinator` fixes and improvements (#4752)
  Fix tests (#4787)
  log concluded disputes (#4785)
  availability-distribution: look for leaf ancestors within the same session (#4596)
  Companion for Use proper bounded vector type for nominations #10601 (#4709)
  Fix release profile (#4778)
  [ci] remove publish-s3-release (#4779)
  Companion for substrate#10632 (#4689)
  [ci] pipeline chores (#4775)
  New changelog scripts (#4491)
chevdor added a commit that referenced this pull request Jan 28, 2022
@chevdor
Fix release profile (#4778)
bd9925e 
* Add codeden-units=1

ref #4311

* opt-level to 3

* Fix opt-level

* Refactor apt-level into the release profile
chevdor added a commit that referenced this pull request Jan 28, 2022
@chevdor
Fix release profile (#4778)
d3e30f8 
* Add codeden-units=1

ref #4311

* opt-level to 3

* Fix opt-level

* Refactor apt-level into the release profile

fix #4780
ordian added a commit that referenced this pull request Jan 28, 2022
@ordian
Merge remote-tracking branch 'origin/wk-prep-v0.9.16-rc7' into refact…
208853c 
…or_check_validation_outputs_release_v0916

* origin/wk-prep-v0.9.16-rc7:
  wrong if-case - backport of #4798 into v0.9.16 (#4800)
  Fix release profile (#4778)
  Update deps
@chevdor chevdor mentioned this pull request Jan 28, 2022
Merged
chevdor added a commit that referenced this pull request Jan 28, 2022
@chevdor @drahnr
@eskimor @bkchr @Lldenaurois @rphmeier @ordian
v0.9.16 rc7 (#4805)
192586a 
* Update deps

* Fix release profile (#4778)

* Add codeden-units=1

ref #4311

* opt-level to 3

* Fix opt-level

* Refactor apt-level into the release profile

fix #4780

* wrong if-case - backport of #4798 into v0.9.16 (#4800)

* fixup

* fmt

* fix tests

* Rk fix sorting 0.9.16 (#4806)

* Fix incomplete sorting.

* fmt.

* Better test.

* Update runtime/parachains/src/disputes.rs

Co-authored-by: Bastian Köcher <[email protected]>

* cargo fmt

Co-authored-by: Bastian Köcher <[email protected]>

* Refactor check validation outputs - Backport of #4727 into v0.9.16 (#4801)

* Move PersistedValidationData check into

* Address feedback

* Remove incorrect comment

* Update runtime/parachains/src/inclusion/mod.rs

* fmt

* Add logging

Co-authored-by: Robert Habermeier <[email protected]>
Co-authored-by: Andronik <[email protected]>

Co-authored-by: Bernhard Schuster <[email protected]>
Co-authored-by: Robert Klotzner <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Lldenaurois <[email protected]>
Co-authored-by: Robert Habermeier <[email protected]>
Co-authored-by: Andronik <[email protected]>
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@chevdor @Wizdave97
Fix release profile (paritytech#4778)
3e89849 
* Add codeden-units=1

ref paritytech#4311

* opt-level to 3

* Fix opt-level

* Refactor apt-level into the release profile
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Feb 17, 2022
@jasl
Port paritytech/polkadot#4778
992eb5c
@Kailai-Wang Kailai-Wang mentioned this pull request Feb 19, 2022
Closed
jasl added a commit to Phala-Network/phala-blockchain that referenced this pull request Feb 21, 2022
@jasl
Port paritytech/polkadot#4778
9afd0df
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chevdor @ordian @ggwpez @bkchr