Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

construct_runtime should bail if pallet have config but not declared #10756

Closed
xlc opened this issue Jan 30, 2022 · 2 comments
Closed

construct_runtime should bail if pallet have config but not declared #10756

xlc opened this issue Jan 30, 2022 · 2 comments

Comments

@xlc
Copy link
Contributor

xlc commented Jan 30, 2022

For many pallets the config is required to make it working properly but it is easy to miss it in construct_runtime and therefore end up in unexpected state.

It really need to be a compile error to prevent inconsistent state.
@xlc
Copy link
Contributor Author

xlc commented Jan 30, 2022

Fixed by the new construct_runtime syntax.

@xlc xlc closed this as completed Jan 30, 2022
@bkchr
Copy link
Member

bkchr commented Jan 30, 2022

For posterity: #9681

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlc @bkchr