Performance issues

[Luncher91]

Hey Patrys,

Thank your bringing such a great extension to vscode. I have developed a symbol parser for VBScript and during my tests I got some files with 25k lines of code or more which contained nearly 4000 symbols.

Your extension seems really chew on that many symbols. It is no show stopper because it appears only on very large files but maybe you know some parts of your code which can be optimized so it won't utilize that much of the CPU.

Thanks man!

Best regards,
Andreas

[patrys]

It would be very interesting to understand what exactly causes it to be slow. Would it be possible for you to profile the tree building function with a symbol provider that reports such a large number of symbols?

[Luncher91]

I tried to create a profile of your extension but I think I am doing it wrong.
To reproduce the lng loading time you have to use a file with some symbols:
longTestFile.zip

load my extension:
vbscript-language-server-client-0.0.7.zip

and set the following setting to get the output of the language server communication:
"vbsLanguageServer.trace.server": "messages",

Fire up your code outline and you should see what i mean. The language server responses just after 100 ms and vscode is loading quite some time until the code outline get displayed.

During my Profiling tests I observed a lot of "Update Layer Tree" actions but I am really not sure if that is coming from your extension or from visual studio code.

[patrys]

Please see if 0.0.12 fixes this. I've reimplemented the tree builder from O(n**2) to ~O(n).

[Luncher91]

Amazing! Thank you for the quick fix!

[patrys]

No worries, the naive implementation stuck as I've never before encountered a file where it made such a difference 😄

[ScottEP]

Talk about timing - I have a 100k-line JSON file that was killing VS Code yesterday because of this & your update has fixed it - thanks! 😄