Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [Menu Toggle] - [disabled function not passing down to button] #11485

Open
ashley-o0o opened this issue Jan 27, 2025 · 1 comment
Open

Comments

@ashley-o0o
Copy link
Contributor

Describe the problem
If the typeahead toggle is disabled, it isn't passing the disabled state down to the button.

Expected behavior
The button should also have the disabled state

Screenshots
Image

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 27, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to Backlog in PatternFly Issues Jan 30, 2025
@thatblindgeye
Copy link
Contributor

Thought I left a comment here earlier today, may have closed the tab before I submitted it.

This may involve 2 parts:

  1. The isDisabled prop on MenuToggle definitely should drill down to the toggle button for a typeahead toggle. Seems like we're not doing that correctly where we're defining the content variable in the component code
  2. Some disabling will fall on the consumer for typeahead toggles, since the MenuToggle doesn't really do anything with whatever is passed to it as children in that case (whether it be a text input or some other button action; in our example code this would be the TextInputGroup and the Button that creates the clear action). We should mention this in documentation (example description) if it isn't already. Without the consumer disabling these things then certain AT can still navigate to the text input and enter text in it, without it being obvious that the text input is meant to be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants