-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work on IOS devices #40
Comments
Running into this issue as well. Were you able to fix it jared? |
Try setting the prop "force" to "ios" to view the ios smart banner in chrome on a computer. |
Actually my work priorities changed and I am no longer working on making this banner for our site. But I was not ever able to get it to work. Cookies were cleared, and I tried to use the force for ios but that didn't work. |
@jaredwilli Sorry about your issue.I've been unable to replicate the issue. |
I can confirm @johnanisere is correct, simulating the User Agent works for testing in the browser. |
I had the same issue. I manipulated "setType(deviceType)" function and changed agent.device.vender === 'iOS' || agent.browser.name === 'Mobile Safari'. I know this way it doesn't support iOS < 6. |
Anyone following up with this repo ? This is still happening in ios devices. Anyone can help ? |
@arpit-appointy @dovvas @jaredwilli the reason that doesn't show on iOS devices its because @patw0929 doesn't want to give it, instead he propose to use the smart banner meta tag for iOS, look at the code:
If you have a iOS version < 6 it will show you. And i'm not saying that this is incorrect, in fact, use the meta tag for iOS:
As Apple suggest: https://developer.apple.com/documentation/webkit/promoting_apps_with_smart_app_banners Obviously, is not customizable. but thats the reason. |
When I try to view the banner when in device mode in chrome devtools, and using an IOS device setting, the banner does not show up. It also doesn't show on actual devices either.
I have seen this on the demo page too for this repo. Any ideas how to get it to work?
The text was updated successfully, but these errors were encountered: