Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KMPAuth for login #189

Open
enthuan opened this issue Mar 8, 2024 · 6 comments
Open

Use KMPAuth for login #189

enthuan opened this issue Mar 8, 2024 · 6 comments

Comments

@enthuan
Copy link
Collaborator

enthuan commented Mar 8, 2024

I found this library and I think it's a good candidate to implement both Google Sign In and Apple Sign In.
I will require an intermediate screen to select Google / Apple sign in

BONUS : Github sign in :)

https://github.com/mirzemehdi/KMPAuth?tab=readme-ov-file

@martinbonnin
Copy link
Contributor

Would be awesome indeed. Passkeys would also be nice. Only thing is it binds us to Firebase auth on the backend, which I'm not 100% how to implement. I'll dig more!

@enthuan
Copy link
Collaborator Author

enthuan commented Mar 8, 2024 via email

@enthuan
Copy link
Collaborator Author

enthuan commented Mar 8, 2024

@martinbonnin
Copy link
Contributor

Nevermind, I was wrong, we already use Firebase auth in the backend. It should work out of the box with Apple/GitHub/other as long as a firebase idToken is passed in the Authentication header. Go for it 👍

@enthuan
Copy link
Collaborator Author

enthuan commented Apr 8, 2024

It's not that easy to implement. KMPAuth doesn't work the same way as the Firebase unofficial lib.
We can retrieve the 'stored' user with KMPAuth, it only manages (AFAIK) the flow of authentication and return a user once.

@martinbonnin
Copy link
Contributor

martinbonnin commented Apr 9, 2024

We could probably "just" store the user locally or so... I was talking signin with @BoD yesterday and would be nice to have to sync bookmarks with the watch. Will dig a bit more. (editted with mandatory "just" :) )

@martinbonnin martinbonnin mentioned this issue Apr 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants