From d108edcc2278c17be9f080a727ad52671ceb044d Mon Sep 17 00:00:00 2001
From: Eitan Seri-Levi <eserilev@ucsc.edu>
Date: Sun, 3 Dec 2023 12:13:55 -0800
Subject: [PATCH] publish_block_v3 should return irrecoveerable errors

---
 validator_client/src/block_service.rs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/validator_client/src/block_service.rs b/validator_client/src/block_service.rs
index aeac9e880f5..cce2219b103 100644
--- a/validator_client/src/block_service.rs
+++ b/validator_client/src/block_service.rs
@@ -366,7 +366,6 @@ impl<T: SlotClock + 'static, E: EthSpec> BlockService<T, E> {
                     .validator_store
                     .get_builder_proposals(&validator_pubkey);
                 let service = self.clone();
-                let log = log.clone();
                 self.inner.context.executor.spawn(
                     async move {
                         if builder_proposals {
@@ -560,7 +559,7 @@ impl<T: SlotClock + 'static, E: EthSpec> BlockService<T, E> {
             metrics::start_timer_vec(&metrics::BLOCK_SERVICE_TIMES, &[metrics::BEACON_BLOCK]);
 
         let current_slot = self.slot_clock.now().ok_or_else(|| {
-            BlockError::Recoverable("Unable to determine current slot from clock".to_string())
+            BlockError::Irrecoverable("Unable to determine current slot from clock".to_string())
         })?;
 
         let randao_reveal = match self
@@ -582,7 +581,7 @@ impl<T: SlotClock + 'static, E: EthSpec> BlockService<T, E> {
                 return Ok(());
             }
             Err(e) => {
-                return Err(BlockError::Recoverable(format!(
+                return Err(BlockError::Irrecoverable(format!(
                     "Unable to produce randao reveal signature: {:?}",
                     e
                 )))
@@ -626,7 +625,7 @@ impl<T: SlotClock + 'static, E: EthSpec> BlockService<T, E> {
                         .get_validator_blocks_v3::<E>(slot, randao_reveal_ref, graffiti.as_ref())
                         .await
                         .map_err(|e| {
-                            BlockError::Recoverable(format!(
+                            BlockError::Irrecoverable(format!(
                                 "Error from beacon node when producing block: {:?}",
                                 e
                             ))