Bug Report: System property placeholder interpolation does not work if property with placeholder comes first in domain.xml/FISH-5855

[kruemelmonstr]

Description

---

Hey Payara Support,

I am currently facing a very strange behaviour: imagine you have two system properties in your domain.xml like this:

<system-property name="property.name.one" value="${property.name.two} one"></system-property>
<system-property name="property.name.two" value="two"></system-property>

After the deployment property "one"s placeholder is not replaced with the value from property two. If change the order of the properties manually and restart the server everything works as expected. A normal restart with order change does not has an impact.

Since I create the whole domain configuration with asadmin command if no direct influence in what order the properties are stored in domain.xml file.

Expected Outcome

The order of the system properties should not have any impact on the placeholder interpolation.

Current Outcome

Placeholder is not replaced in property string

Steps to reproduce

Environment

• Distribution:
  Server Full Profile - Payara Server 4.1.2.191 #badassfish (build 872)
• JDK Version:
  ZuluJDK 8u282
• Operating System:
  Linux

[AlanRoth]

Hi, thanks for raising the issue,

Are you able to reproduce it in the latest Payara Community version? Can you also provide a self-contained reproducer with the steps you take to cause this bug?

Thank you,
Alan

[kruemelmonstr]

Hey @AlanRoth
I've created you a short example for you to reproduce the the problem.

https://github.com/kruemelmonstr/payara-property-replacement-bug
Hope that helps :)

Regards, Fabian

[AlanRoth]

Hi Fabian,

Thank you for the reproducer, however you are using version 4.1.2.181 - if you require support for older versions in maintenance then I can refer you to the sales team to discuss a license for Enterprise or the inquire on the Payara Forum.

Are you able to provide a reproducer using the latest Payara Community version 5.2021.4? You may find that the bug has already been fixed in recent versions.

Thank you for your understanding,
Alan

[kruemelmonstr]

Hey @AlanRoth,

Sorry for the delayed response - I havn't seen your reply. Unfortunately I was also able to reproduced this behaviour successfully with the latest community version 5.2021.4 as requested. So the defect has not been fixed completly.

See the updated version kruemelmonstr/payara-property-replacement-bug@74ae76e

Regards,
Fabian

[shub8968]

Hi @kruemelmonstr,

I am able to reproduce this issue. I have raised an internal issue with JIRA FISH-5855. Thanks. It may take a while to fix the issue. You are free to submit a PR to fix this issue if you feel confident to do so.