Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments #7097

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 28, 2024

Description

Developer can copy all their dependencies to <domain_dir>/lib/warlibs/ and use no-dependency skinny-war
for developer deployments, significantly improving deployment times.

Able to deploy real applications in half a second on my machine that used to take 15+ seconds

Fixes #6405

Important info

This PR is based on #7032 until that gets merged.

Documentation updates

Applications need to be deployed with the following snippet to asadmin: --properties warlibs=true to take advantage of shared WAR libraries. This is to prevent unnecessary loading of shared libraries with non-development applications, such as admin console or other applications that will fail if shared WAR libraries are loaded.

Testing

Tested skinny WAR deployment

@lprimak
Copy link
Contributor Author

lprimak commented Dec 4, 2024

@Pandrex247 This one should be ready to go as soon as it's dependent #7032 is merged

@Pandrex247 Pandrex247 changed the title Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments FISH-10286 Enhancement: Use <domain_dir>/lib/warlibs to enable fast devopment deployments Dec 5, 2024
@lprimak lprimak marked this pull request as ready for review December 6, 2024 02:45
@lprimak lprimak force-pushed the warlib branch 2 times, most recently from 229ffca to c9f272a Compare December 12, 2024 03:27
…I-enabled library JARs

- correctly copy BDA sets for each war in EAR
- Make WAR's CDI beans available in EAR-libs
- read web-fragment.xml from EAR-libs
- processing ear-lib manifest
- de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList
- made some structures final (cleanup)
- fixed ear and concurrent classloader leaks, including refactored reflection caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI not scanning bean libraries in domain applib or lib directories/FISH-7871
1 participant