Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔁 Upgrade to Solidity Version 0.8.22 #20

Closed
pcaversaccio opened this issue Oct 25, 2023 · 3 comments · Fixed by #22
Closed

🔁 Upgrade to Solidity Version 0.8.22 #20

pcaversaccio opened this issue Oct 25, 2023 · 3 comments · Fixed by #22
Assignees
@pcaversaccio
Labels
dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups
Milestone
1.0.0

Comments

@pcaversaccio
Copy link
Owner

pcaversaccio commented Oct 25, 2023 •
edited
Loading

@pcaversaccio pcaversaccio self-assigned this Oct 25, 2023
@pcaversaccio pcaversaccio added dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups labels Oct 25, 2023
@pcaversaccio pcaversaccio added this to the 1.0.0 milestone Oct 25, 2023
@pcaversaccio
Copy link
Owner Author

@mds1 do you agree with this upgrade as well? It will also help to refactor some of the redundant event definitions in the Foundry tests due to the ICE of Solidity Version 0.8.21.

@mds1
Copy link
Collaborator

mds1 commented Oct 25, 2023

In general I'm ok with upgrading. My only suggestion is we might want to wait a few weeks before deploying for production if we're using a brand new solc version, since in the past there's occasionally been small bugs found after new releases, so waiting just gives some extra confidence around we're not subject to one of them

@pcaversaccio
Copy link
Owner Author

Yeah, I fully agree on waiting a few weeks.

@pcaversaccio pcaversaccio mentioned this issue Oct 30, 2023
Merged
3 tasks
@pcaversaccio pcaversaccio linked a pull request Oct 30, 2023 that will close this issue
♻️ Refactor: Remove Test Complexity, Gas Optimisations, Remove Metadata Hash #22
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcaversaccio pcaversaccio

Labels
dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Milestone
1.0.0
2 participants
@mds1 @pcaversaccio